Changeset 638

Timestamp:

05/23/2014 05:48:41 AM (12 years ago)

Author:

coffee2code

Message:

Code Reference: Separate get_current_version() into functions to retrieve actual version and one to retrieve its term object. See #484.

• get_current_version() now returns a string of the actual version of parsed WP code (or best effort)
• Prefer 'wp_parser_imported_wp_version' option value as set in newer version of parser
• Add get_current_version_term() to return wp-parser-since term object for the major version of parsed WP code
• Add argument to permit get_current_version_term() to return term object for actual version

Location:

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer

Files:

• inc/template-tags.php (modified) (2 diffs)
• page-reference-landing.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/template-tags.php

@@ -250 +250 @@
 
         /**
-         * Get current (latest) since major version (X.Y.0) term object.
-         *
+         * Get current version of the parsed WP code.
+         *
+         * Prefers the 'wp_parser_imported_wp_version' option value set by more
+         * recent versions of the parser. Failing that, it checks the
+         * WP_CORE_LATEST_RELEASE constant (set on wp.org) though this is not
+         * guaranteed to be the latest parsed version. Failing that, it uses a
+         * hardcoded value, which isn't guaranteed either.
+         *
+         * @return string
+         */
+        function get_current_version() {
+                $current_version = get_option( 'wp_parser_imported_wp_version' );
+
+                if ( empty( $current_version ) ) {
+                        $current_version = defined( 'WP_CORE_LATEST_RELEASE' ) ? WP_CORE_LATEST_RELEASE : '3.9.1';
+                }
+
+                return $current_version;
+        }
+
+        /**
+         * Get current (latest) version of the parsed WP code as a wp-parser-since
+         * term object.
+         *
+         * By default returns the major version (X.Y.0) term object because minor
+         * releases rarely add enough, if any, new things to feature.
+         *
+         * @param  boolean $ignore_minor Use the major release version X.Y.0 instead of the actual version X.Y.Z?
          * @return object
          */
-        function get_current_version() {
-
-                $current_version = defined( 'WP_CORE_LATEST_RELEASE' ) ? WP_CORE_LATEST_RELEASE : '3.9';
-                $version_parts = explode( '.', $current_version, 3 );
-                if ( count( $version_parts ) == 2 ) {
-                        $version_parts[] = '0';
-                } else {
-                        $version_parts[2] = '0';
-                }
-                $current_version = implode( '.', $version_parts );
+        function get_current_version_term( $ignore_minor = true ) {
+                $current_version = get_current_version();
+
+                if ( $ignore_minor ) {
+                        $version_parts = explode( '.', $current_version, 3 );
+                        if ( count( $version_parts ) == 2 ) {
+                                $version_parts[] = '0';
+                        } else {
+                                $version_parts[2] = '0';
+                        }
+                        $current_version = implode( '.', $version_parts );
+                }
 
                 $version = get_terms( 'wp-parser-since', array(
@@ -570 +598 @@
 
 }
-

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/page-reference-landing.php

@@ -32 +32 @@
                                 <div class="new-in-guide section two-columns clear">
                                         <div class="widget box gray">
-                                                <h3 class="widget-title"><?php $version = DevHub\get_current_version(); printf( __( 'New in WordPress %s:', 'wporg' ), $version->name ); ?></h3>
+                                                <h3 class="widget-title"><?php $version = DevHub\get_current_version_term(); printf( __( 'New in WordPress %s:', 'wporg' ), $version->name ); ?></h3>
                                                 <div class="widget-content">
                                                         <ul class="unordered-list no-bullets">