Changeset 6464 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/standalone/class-plugins-info-api.php

Timestamp:

01/30/2018 05:40:49 AM (5 years ago)

Author:

dd32

Message:

Plugin Directory: API: rejig how the error handling in [6463] is handled - The old behaviour is now only present if the constant is defined as false.

See #111

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/standalone/class-plugins-info-api.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/standalone/class-plugins-info-api.php

@@ -85 +85 @@
 
         // Backwards compatibility; the API returns null in case of error..
-        if ( isset( $response['error'] ) && ( ! defined( 'PLUGINS_API_SUPPORTS_ERRORS' ) || ! PLUGINS_API_SUPPORTS_ERRORS ) ) {
+        // This is now feature-flagged by the PLUGINS_API_SUPPORTS_ERRORS constant which is defined as `true` in info/1.2 and later.
+        if ( isset( $response['error'] ) && ( defined( 'PLUGINS_API_SUPPORTS_ERRORS' ) && ! PLUGINS_API_SUPPORTS_ERRORS ) ) {
             $this->output( null );
             return;