Changeset 6479 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-readme-validator.php

Timestamp:

01/30/2018 11:30:30 PM (7 years ago)

Author:

obenland

Message:

Plugins: Encode readme data before submitting it

Props benlk.
Fixes #3230.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-readme-validator.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-readme-validator.php

@@ -34 +34 @@
 
             <p><?php _e( '... or paste your <code>readme.txt</code> here:', 'wporg-plugins' ); ?></p>
-            <form method="post" action="">
-                <textarea rows="20" cols="100" name="readme_contents" placeholder="=== Plugin Name ===">
+                <textarea rows="20" cols="100" name="readme_visible" placeholder="=== Plugin Name ===">
                     <?php
                     if ( isset( $_POST['readme_contents'] ) ) {
-                        echo esc_textarea( wp_unslash( $_POST['readme_contents'] ) );
+                        echo esc_textarea( base64_decode( wp_unslash( $_POST['readme_contents'] ) ) );
                     }
                     ?>
                 </textarea>
+                <form id="readme-data" method="post" action="">
+                    <textarea class="screen-reader-text" rows="20" cols="100" name="readme_contents">
+                        <?php
+                        if ( isset( $_POST['readme_contents'] ) ) {
+                            echo esc_textarea( base64_decode( wp_unslash( $_POST['readme_contents'] ) ) );
+                        }
+                        ?>
+                    </textarea>
                 <p><input type="submit" class="button button-secondary" value="<?php esc_attr_e( 'Validate!', 'wporg-plugins' ); ?>" /></p>
             </form>
+            <script>
+                document.getElementById( 'readme-data' ).addEventListener( 'submit', function() {
+                    var readmeInputs = document.getElementsByTagName( 'textarea' );
+
+                    readmeInputs[1].value = window.btoa( readmeInputs[0].value );
+
+                    return true;
+                } );
+            </script>
         </div>
         <?php
@@ -56 +72 @@
 
         } elseif ( ! empty( $_POST['readme_contents'] ) ) {
-            $errors = Validator::instance()->validate_content( wp_unslash( $_REQUEST['readme_contents'] ) );
+            $errors = Validator::instance()->validate_content( base64_decode( wp_unslash( $_REQUEST['readme_contents'] ) ) );
 
         } else {