Changeset 6494

Timestamp:

01/31/2018 11:37:14 PM (8 years ago)

Author:

obenland

Message:

Plugins: Encode faq title rather than rolling my own

Props ocean90.
Closes #3319.

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/js/section-faq.js (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/js/section-faq.js

@@ -1 +1 @@
 ( function( $ ) {
         var questions = $( 'dt', '#faq' );
-        var hash      = window.location.hash.replace( /[^a-z0-9-#]/gi, '' );
 
         questions
@@ -11 +10 @@
                         // If there is no ID, create our own.
                         if ( ! id ) {
-                                id = '#' + $question.text().toLowerCase().replace( /[^\w\s]/gi, '' ).replace( /\s/gi, '-' );
+                                id = '#' + encodeURIComponent( $question.text().toLowerCase() );
                                 $question.attr( 'id', id );
                         }
@@ -36 +35 @@
                         } ).next( 'dd' ).slideToggle( 200 );
 
-                        if ( hash ) {
+                        if ( window.location.hash ) {
                                 window.scrollTo( 0, $question.offset().top );
                         }
                 } );
 
-        if ( hash ) {
-                questions.find( '[href="' + hash + '"]' ).trigger( 'click' );
+        if ( window.location.hash ) {
+                questions.find( '[href="' + window.location.hash + '"]' ).trigger( 'click' );
         }
 } )( jQuery );