Changeset 6763

Timestamp:

02/26/2018 12:45:25 PM (9 years ago)

Author:

tellyworth

Message:

2FA: move inline css to external file.

Also improve client-side input validation.

See #77

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-two-factor

Files:

• css/login.css (modified) (1 diff)
• providers/class-wporg-two-factor-secondary.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-two-factor/css/login.css

@@ -2 +2 @@
         border: 1px solid #EE0000;
 }
+body.login-action-backup_2fa .backup-methods-wrap {
+        display: none;
+}
+body.login-action-backup_2fa input[name="two-factor-backup-resend"] {
+}

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-two-factor/providers/class-wporg-two-factor-secondary.php

@@ -44 +44 @@
                 <p>
                         <label for="authcode"><?php esc_html_e( 'Verification Code:', 'wporg' ); ?></label>
-                        <input type="tel" name="two-factor-backup-code" id="authcode" class="input" value="" size="20" pattern="[0-9]*" />
+                        <input type="tel" name="two-factor-backup-code" id="authcode" class="input" value="" size="20" pattern="[0-9]{6,20}" title="<?php esc_attr_e( 'Codes are at least 6 decimal digits' ); ?>" />
                         <?php submit_button( __( 'Authenticate', 'wporg' ) ); ?>
                 </p>
@@ -80 +80 @@
 
                 // Add some CSS for this clss.
-                add_action( 'login_head', [ $this, 'add_styles' ] );
+                wp_enqueue_style( 'two-factor-login', plugins_url( '/css/login.css', dirname( __FILE__ ) ) );
 
                 foreach ( $providers as $class => $path ) {
@@ -95 +95 @@
 
                 return parent::__construct();
-        }
-
-        // Add some specific styles for this class.
-        public function add_styles() {
-                if ( isset( $_GET['provider'] ) && $_GET['provider'] === __CLASS__ ) {
-                        echo '<style>
-                                body.login-action-backup_2fa .backup-methods-wrap {
-                                        display: none;
-                                }
-                                body.login-action-backup_2fa input[name="two-factor-backup-resend"] {
-
-                                }
-                        </style>';
-                }
         }