Changeset 6833 for sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-qbo-client/wordcamp-qbo-client.php

Timestamp:

03/07/2018 01:45:38 AM (7 years ago)

Author:

iandunn

Message:

WordCamp QBO: Store classes in site option for reliability.

Storing it in a transient often causes the data to be empty when the QBO connection is unavailable.

This is also a good opportunity to remove some of the unnecessary "middle man" code from the wordcamp-qbo-client experiment, now that it's clear that the tangible drawbacks (lots of unnecessary, duplicated, unintuitive code) are worse than the intangible benefits (future-proofing for the unlikely event that we'll switch to a decentralized hosting model in the future).

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-qbo-client/wordcamp-qbo-client.php (modified) (1 diff)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-qbo-client/wordcamp-qbo-client.php

@@ -91 +91 @@
      */
     public static function get_classes() {
-        $cache_key = md5( 'wordcamp-qbo-client:classes' );
-        $cache = get_transient( $cache_key );
-
-        if ( $cache !== false )
-            return $cache;
-
-        $request_url = esc_url_raw( self::$api_base . '/classes/' );
-        $request_args = array(
-            'timeout' => self::REMOTE_REQUEST_TIMEOUT,
-            'headers' => array(
-                'Content-Type' => 'application/json',
-                'Authorization' => self::_get_auth_header( 'get', $request_url ),
-            ),
-        );
-        $response = wp_remote_get( $request_url, $request_args );
-
-        Logger\log( 'remote_request', compact( 'request_url', 'request_args', 'response' ) );
-
-        $classes = array();
-
-        if ( ! is_wp_error( $response ) && wp_remote_retrieve_response_code( $response ) == 200 ) {
-            $body = json_decode( wp_remote_retrieve_body( $response ), true );
-            if ( ! empty( $body ) && is_array( $body ) )
-                $classes = $body;
-        }
-
-        if ( $classes ) {
-            set_transient( $cache_key, $classes, 12 * HOUR_IN_SECONDS );
-        }
-
-        return $classes;
+        return get_site_option( 'wordcamp_qbo_classes' );
     }