Changeset 6857

Timestamp:

03/10/2018 10:08:31 PM (7 years ago)

Author:

iandunn

Message:

WordCamp PHPCS: Add more excludes.

File:

• sites/trunk/wordcamp.org/phpcs.xml.dist (modified) (5 diffs)

sites/trunk/wordcamp.org/phpcs.xml.dist

@@ -46 +46 @@
             align ? and : in multiple ternary operator statements
             don't un-align params in function calls - e.g., multiple add_meta_box( $a, $b, $c, $d, $e, $f, $g ) calls should have the params aligned.
+            file missing `defined WPINC or die` at start
+            don't add `@return void`, just leave return empty
+            no space before ++,etc operators: e.g., `$attempt_count ++;`
+            replace explicit references to central.wordcamp.org / ID `5` with `is_main_site()` or `get_main_site_id()`
+            anonymous functions used with add_(action|filter), and maybe other places can detect w/out false positives. don't be lazy. should only be used with cases like array_filter.
 
         Maybe add WordCamp\Remote_CSS\output_cached_css to customEscapingFunctions or whichever param is most appropriate
@@ -90 +95 @@
         <exclude name="Squiz.Strings.ConcatenationSpacing.PaddingFound" />
 
+        <!-- todo get_speaker_from_user_id() meta_query should not have to line up with post_status
+        <rule ref="WordPress.Arrays.MultipleStatementAlignment">
+            <properties>
+                <property name="alignMultilineItems" value="never" />
+            </properties>
+        </rule>
+        -->
+
         <!-- Warn about mis-aligned array items, but don't automatically "fix" them, because arrays in function calls get extra lines added.
              See https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/1305 -->
-        <exclude phpcbf-only="true" name="WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned" />
-        <exclude phpcbf-only="true" name="PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket" />
-        <exclude phpcbf-only="true" name="PEAR.Functions.FunctionCallSignature.CloseBracketLine" />
+        <exclude phpcbf-only="true" name="PEAR.Functions.FunctionCallSignature" />
+
+        <!-- The <?php and ?> tags can't be on a line by itself inside a <textarea>, otherwise it'll add whitespace to the content. -->
+        <exclude name="Squiz.PHP.EmbeddedPhp.ContentBeforeOpen" />
+        <exclude name="Squiz.PHP.EmbeddedPhp.ContentAfterEnd"   />
     </rule>
 
@@ -104 +119 @@
         <exclude name="Squiz.Commenting.FunctionComment.MissingParamTag" />
         <exclude name="Generic.Commenting.DocComment.MissingShort" />
+        <exclude name="Squiz.Commenting.VariableComment.Missing" />
 
         <!-- I don't see how these are useful. -->
@@ -116 +132 @@
         <!-- It's not wrong for WordPress plugin file headers. -->
         <exclude name="Squiz.Commenting.FileComment.WrongStyle" />
+
+        <!-- Class comments are generally not useful, so they're left out, but then PHPCS confuses the plugin headers for a class comment -->
+        <exclude name="Squiz.Commenting.ClassComment.WrongStyle" />
     </rule>
 
@@ -125 +144 @@
         <exclude name="WordPress.VIP.RestrictedFunctions.file_get_contents_file_get_contents" />
         <exclude name="WordPress.VIP.RestrictedFunctions.get_posts_get_posts" />
+        <exclude name="WordPress.VIP.RestrictedFunctions.switch_to_blog_switch_to_blog" />
+        <exclude name="WordPress.VIP.RestrictedVariables.cache_constraints___SERVER__REMOTE_ADDR__" />
 
         <!-- This is too strict. -->