Changeset 6873

Timestamp:

03/14/2018 05:14:59 AM (7 years ago)

Author:

dd32

Message:

Plugin Directory: Attempt to avoid storing invalid dates in postmeta for status changes. If the post modified date isn't available, assume now.

I'm not entirely sure post_modified_gmt is the correct field to use here, I suspect post_modified would be better, or perhaps even just using time() in all cases, but once again, I'm not sure why post_modified_gmt was used here instead.

Fixes #3511.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-status-transitions.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-status-transitions.php

@@ -151 +151 @@
 
         // Record the time a plugin was transitioned into a specific status.
-        update_post_meta( $post->ID, "_{$new_status}", strtotime( $post->post_modified_gmt ) );
+        if ( '0000-00-00 00:00:00' === $post->post_modified_gmt ) {
+            // Assume now.
+            update_post_meta( $post->ID, "_{$new_status}", time() );
+        } else {
+            update_post_meta( $post->ID, "_{$new_status}", strtotime( $post->post_modified_gmt ) );
+        }
     }