Changeset 689

Timestamp:

06/07/2014 06:07:05 PM (10 years ago)

Author:

coffee2code

Message:

Code Reference: JS tweaks: proper variable naming, correct inline docs regarding height calculation; adjust expanded height. props atimmer

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/js/function-reference.js (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/js/function-reference.js

@@ -5 +5 @@
  */
 ( function( $ ) {
-    var $sourceContent, $sourceCodeContainer, $sourceCodeTable, $showCompleteSource, $lessCompleteSource, $sourceCollapsedHeight;
+    var $sourceContent, $sourceCodeContainer, $sourceCodeTable, $showCompleteSource, $lessCompleteSource, sourceCollapsedHeight;
 
     function toggleCompleteSource( e ) {
@@ -11 +11 @@
 
         if ( $showCompleteSource.is(':visible') ) {
-            var heightGoal = $sourceCodeTable.height() + 37; // takes into consideration potential x-scrollbar
+            var heightGoal = $sourceCodeTable.height() + 45; // takes into consideration potential x-scrollbar
         } else {
-            var heightGoal = $sourceCollapsedHeight;
+            var heightGoal = sourceCollapsedHeight;
         }
 
@@ -33 +33 @@
         $sourceCodeTable = $sourceContent.find( 'table' );
 
-        // 1em (margin) + 20 * 17px. Lines are 1.1em which rounds to 17px: calc( 1em + 17px * 20 ).
+        // 1em (margin) + 10 * 17px + 10. Lines are 1.1em which rounds to 17px: calc( 1em + 17px * 10 + 10 ).
         // Extra 10px added to partially show next line so it's clear there is more.
-        $sourceCollapsedHeight = 196;
+        sourceCollapsedHeight = 196;
 
-        if ( ( $sourceCollapsedHeight - 12 ) < $sourceCodeTable.height() ) {
+        if ( ( sourceCollapsedHeight - 12 ) < $sourceCodeTable.height() ) {
 
             // Do this with javascript so javascript-less can enjoy the total sourcecode
-            $( '.source-code-container' ).css( { height: $sourceCollapsedHeight + 'px' } );
+            $( '.source-code-container' ).css( { height: sourceCollapsedHeight + 'px' } );
 
             $showCompleteSource = $( '.show-complete-source' );