Changeset 6996

Timestamp:

03/31/2018 01:46:19 AM (8 years ago)

Author:

iandunn

Message:

WP15: Unset referenced $event after loop to avoid duplicates.

After looping through an array by reference, the final value remains a reference unless it's unset. If you then reuse that variable in a future loop, it results in one of the items being overwritten by another. In this case, that meant that the Arnhem event was displayed twice, but the New Delhi was skipped.

File:

• sites/trunk/wp15.wordpress.net/public_html/content/plugins/wp15-meetup-events/wp15-meetup-events.php (modified) (1 diff)

sites/trunk/wp15.wordpress.net/public_html/content/plugins/wp15-meetup-events/wp15-meetup-events.php

@@ -205 +205 @@
                 $event['time'] = get_local_formatted_date( $event['time'], $event['timezone'] );
         }
+        unset( $event ); // Destroy the reference to restore expected behavior; see https://stackoverflow.com/a/4969286/450127.
 
         usort( $events, __NAMESPACE__ . '\sort_events' );