Changeset 701

Timestamp:

06/12/2014 10:32:24 PM (12 years ago)

Author:

iandunn

Message:

WordCamp Organizer Reminders: Prevent retroactively sending new e-mails to old WordCamps.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-organizer-reminders/wcor-mailer.php (modified) (3 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-organizer-reminders/wcor-mailer.php

@@ -322 +322 @@
      * isn't scheduled until 2 months before the start). When that happens, we want to send all the e-mails that they've missed.
      *
+     * We don't want newly created messages to be retroactively sent to all WordCamps that occurred before the e-mail was created though, so we
+     * only send messages to camps that were created after the e-mail was created.
+     *
      * @todo It'd be nice to have some unit tests for this function, since there are a lot of different cases, but it seems like that might be
      * hard to do because of having to mock get_post_meta(), current_time(), etc. We could pass that info in, but that doesn't seem very elegant.
@@ -331 +334 @@
      */
     protected function timed_email_is_ready_to_send( $wordcamp, $email, $sent_email_ids ) {
-        $ready      = false;
+        $ready = false;
+
+        if ( strtotime( $wordcamp->post_date ) < strtotime( $email->post_date ) ) {
+            return $ready;
+        }
+
         $send_when  = get_post_meta( $email->ID, 'wcor_send_when', true );
         $start_date = get_post_meta( $wordcamp->ID, 'Start Date (YYYY-mm-dd)', true );
@@ -339 +347 @@
             $end_date = $start_date;
         }
-        
+
         if ( ! in_array( $email->ID, $sent_email_ids ) ) {
             if ( 'wcor_send_before' == $send_when ) {