Changeset 7027 for sites/trunk/wordcamp.org/public_html/wp-content/plugins

Timestamp:

04/04/2018 07:41:21 PM (7 years ago)

Author:

iandunn

Message:

WordCamp Payments: Verify payload signature before unslashing data.

The signature is generated on slashed data, so it needs to be verified against slashed data as well. Otherwise there are cases where the verification will incorrectly fail. For example, Bogotá gets encoded as Bogot\u00e1, but is Bogotu00e1 after being unslashed, so it won't match the original.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/sponsor-payment-stripe.php (modified) (1 diff)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/sponsor-payment-stripe.php

@@ -224 +224 @@
 
             // Make sure our data hasn't been altered.
-            $payment_data_str = wp_unslash( $payment_data_json );
-
-            if ( ! hash_equals( hash_hmac( 'sha256', $payment_data_str, $data['keys']['hmac_key'] ), $payment_data_signature ) ) {
+
+            if ( ! hash_equals( hash_hmac( 'sha256', $payment_data_json, $data['keys']['hmac_key'] ), $payment_data_signature ) ) {
                 $data['errors'][] = 'Could not verify payload signature.';
                 return;
             }
 
-            $payment_data = json_decode( $payment_data_str, true );
+            $payment_data = json_decode( wp_unslash( $payment_data_json ), true );
 
             switch ( $payment_data['payment_type'] ) {