Changeset 707 for sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook/inc/table-of-contents.php

Timestamp:

06/17/2014 12:38:46 AM (11 years ago)

Author:

coffee2code

Message:

Handbook plugin: prevent pre-existing PHP warnings

• Explicitly declare array values before use (and check value before use in str_replace())
• Explicitly declare statically referenced methods as static
• Add instance arg to widgets()

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook/inc/table-of-contents.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook/inc/table-of-contents.php

@@ -73 +73 @@
         $items = $this->get_tags( $tag, $content );
         $first = true;
+        $matches = array();
+        $replacements = array();
 
-        foreach ($items as $item) {
+        foreach ( $items as $item ) {
             $replacement = '';
             $matches[] = $item[0];
@@ -89 +91 @@
         }
 
-        $content = str_replace( $matches, $replacements, $content );
+        if ( $replacements ) {
+            $content = str_replace( $matches, $replacements, $content );
+        }
 
         return $content;