Changeset 7131

Timestamp:

04/18/2018 10:11:44 PM (6 years ago)

Author:

coreymckrill

Message:

WordCamp Site Cloner: Cache site list in an option instead of a transient

Having the site list in a transient was unstable because occasionally the
transient had expired but the cache hadn't been primed again yet.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-site-cloner/wordcamp-site-cloner.php (modified) (3 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-site-cloner/wordcamp-site-cloner.php

@@ -14 +14 @@
 
 const PRIME_SITES_CRON_ACTION      = 'wcsc_prime_sites';
-const WORDCAMP_SITES_TRANSIENT_KEY = 'wcsc_sites';
+const WORDCAMP_SITES_OPTION_KEY = 'wcsc_sites';
 
 /**
@@ -168 +168 @@
 function sites_endpoint() {
     $sites        = array();
-    $cached_sites = get_site_transient( WORDCAMP_SITES_TRANSIENT_KEY );
+    $cached_sites = get_site_option( WORDCAMP_SITES_OPTION_KEY, array() );
 
     if ( $cached_sites ) {
@@ -193 +193 @@
     }
 
-    // Keep the cache longer than needed, just to be sure that it doesn't expire before the cron job runs again
-    // todo This shouldn't be a transient, it should just be a regular option.
-    //      Transients aren't guaranteed to exist until they expire, so it could expire before the next cron runs
-    set_site_transient( WORDCAMP_SITES_TRANSIENT_KEY, get_wordcamp_sites(), DAY_IN_SECONDS * 2 );
+    update_site_option( WORDCAMP_SITES_OPTION_KEY, get_wordcamp_sites() );
 }