Changeset 721

Timestamp:

06/24/2014 08:42:32 PM (10 years ago)

Author:

samuelsidler

Message:

Trac notifications plugin: Fix tabs vs spaces; make code more consistent and readable. Props SergeyBiryukov. Fixes #332

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/trac-notifications/trac-components.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/trac-notifications/trac-components.php

@@ -237 +237 @@
         echo '<h3>Help maintain this component</h3>';
 
-        if ( $maintainers = get_post_meta( $post->ID, '_active_maintainers', true ) ) {
+        $maintainers = get_post_meta( $post->ID, '_active_maintainers', true );
+        if ( $maintainers ) {
+            $maintainers = array_map( 'trim', explode( ',', $maintainers ) );
             echo 'Component maintainers: ';
             echo '<ul class="maintainers">';
-            foreach ( array_map( 'trim', explode( ',', $maintainers ) ) as $maintainer ) {
-                echo '<li><a href="//profiles.wordpress.org/' . esc_attr( $maintainer ) . '"><img width="36" height="36" src="//wordpress.org/grav-redirect.php?user=' . esc_attr( $maintainer ) . '&amp;s=36" /></a> ' . $maintainer . '</li>';
+            foreach ( $maintainers as $maintainer ) {
+                echo '<li><a href="//profiles.wordpress.org/' . esc_attr( $maintainer ) . '">';
+                echo '<img width="36" height="36" src="//wordpress.org/grav-redirect.php?user=' . esc_attr( $maintainer ) . '&amp;s=36" /></a> ' . $maintainer . '</li>';
             }
             echo "</ul>\n\n";
@@ -251 +254 @@
         $followers = $this->trac->get_col( $this->trac->prepare( "SELECT username FROM _notifications WHERE type = 'component' AND value = %s", $post->post_title ) );
         if ( $followers ) {
-            echo 'Contributors following this component:';
-      echo '<ul class="followers">';
+            echo 'Contributors following this component: ';
+            echo '<ul class="followers">';
             foreach ( $followers as $follower ) {
                 $follower = esc_attr( $follower );
@@ -258 +261 @@
                 echo '<img width="36" height="36" src="//wordpress.org/grav-redirect.php?user=' . $follower . '&amp;s=36" /></a></li>';
             }
-      echo '</ul>';
+            echo '</ul>';
         }