Changeset 7226

Timestamp:

05/24/2018 07:40:14 PM (7 years ago)

Author:

coreymckrill

Message:

WordCamp: Fix data export for wcb_organizer

In the case where there was no valid user account associated with the
given email address, the query for the Organizer post type was being
run with no meta query attached, so all Organizer posts were returned.
This fixes it so the query doesn't happen at all when there is no valid
user account.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wc-post-types/inc/privacy.php (modified) (5 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wc-post-types/inc/privacy.php

@@ -10 +10 @@
 defined( 'WPINC' ) || die();
 
-use WP_Query, WP_User;
+use WP_Query, WP_User, WP_Error;
 
 add_filter( 'wp_privacy_personal_data_exporters', __NAMESPACE__ . '\register_personal_data_exporters' );
@@ -114 +114 @@
 
     $post_query = get_wc_posts( $post_type, $email_address, $page );
+
+    if ( is_wp_error( $post_query ) ) {
+        return [
+            'data' => [],
+            'done' => true,
+        ];
+    }
 
     foreach ( (array) $post_query->posts as $post ) {
@@ -209 +216 @@
  * @param int    $page
  *
- * @return WP_Query
+ * @return WP_Query|WP_Error
  */
 function get_wc_posts( $post_type, $email_address, $page ) {
@@ -237 +244 @@
                 $meta_query[] = [
                     [
-                        'key' => '_wcpt_user_id',
+                        'key'   => '_wcpt_user_id',
                         'value' => $user->ID,
+                        'type'  => 'NUMERIC',
                     ],
                 ];
@@ -263 +271 @@
                 $meta_query = [
                     [
-                        'key' => '_wcpt_user_id',
+                        'key'   => '_wcpt_user_id',
                         'value' => $user->ID,
+                        'type'  => 'NUMERIC',
                     ],
                 ];
 
                 $query_args['meta_query'] = $meta_query;
+            } else {
+                $query_args = [];
             }
             break;
     }
 
+    if ( empty( $query_args ) ) {
+        return new WP_Error();
+    }
+
     return new WP_Query( $query_args );
 }