Changeset 723

Timestamp:

06/26/2014 06:25:39 PM (10 years ago)

Author:

iandunn

Message:

WordCamp Post Types: Add note about fragile speaker name lookup.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wc-post-types/wc-post-types.php (modified) (1 diff)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wc-post-types/wc-post-types.php

@@ -1216 +1216 @@
                 continue;
 
-            // Look for speakers by their names.
+            /*
+             * Look for speakers by their names.
+             *
+             * @todo - This is very fragile, it fails if the speaker name has a tab character instead of a space
+             * separating the first from last name, or an extra space at the end, etc. Those situations often arise
+             * from copy/pasting the speaker data from spreadsheets. Moving to automated speaker submissions and
+             * tighter integration with WordPress.org usernames should avoid this, but if not we should do something
+             * here to make it more forgiving.
+             */
             $speaker = get_page_by_title( $speaker_name, OBJECT, 'wcb_speaker' );
             if ( $speaker )