Changeset 7274

Timestamp:

06/06/2018 05:25:49 AM (6 years ago)

Author:

dd32

Message:

Plugin Directory: Include the version field in the comparisons for which plugins update_source records are out of date.

Fixes #3654

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-api-update-updater.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-api-update-updater.php

@@ -19 +19 @@
         global $wpdb;
 
+        // Note: `left( pm.meta_value, 128 )` is due to the short `version` field length and some plugins with absurdly long version strings.
         $out_of_date_plugins = $wpdb->get_col(
             "SELECT p.post_name
             FROM {$wpdb->posts} p
                 LEFT JOIN {$wpdb->prefix}update_source u ON p.ID = u.plugin_id
+                LEFT JOIN {$wpdb->postmeta} pm ON p.ID = pm.post_id AND pm.meta_key = 'version'
             WHERE
                 p.post_type = 'plugin'
@@ -32 +34 @@
                     u.plugin_id IS NULL OR
                     u.last_updated != p.post_modified OR
+                    ( u.version != pm.meta_value AND u.version != left( pm.meta_value, 128 ) ) OR
                     ( u.available = 1 AND (p.post_status != 'publish' AND p.post_status != 'disabled' ) ) OR
                     ( u.available = 0 AND (p.post_status = 'publish' OR p.post_status = 'disabled' ) )