Changeset 7276

Timestamp:

06/06/2018 05:39:51 PM (7 years ago)

Author:

obenland

Message:

Developers: Keep using AJAX for multiple votes

Fixes a regression where the AJAX handler was not working for dynamically added voting links.

Props keesiemeijer.
Fixes #3606.

Location:

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer

Files:

• inc/user-content-voting.php (modified) (4 diffs)
• js/user-notes-voting.js (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/user-content-voting.php

@@ -65 +65 @@
         // Only need to enqueue voting-related resources if there are comments to vote on.
         if ( self::user_can_vote() && is_singular() && '0' != get_comments_number() ) {
-            wp_register_script( 'wporg-developer-user-notes-voting', get_template_directory_uri() . '/js/user-notes-voting.js', array( 'wp-a11y' ), '20180118', true );
+            wp_register_script( 'wporg-developer-user-notes-voting', get_template_directory_uri() . '/js/user-notes-voting.js', array( 'wp-a11y' ), '20180606', true );
             wp_localize_script( 'wporg-developer-user-notes-voting', 'ajaxurl', admin_url( 'admin-ajax.php' ) );
             wp_enqueue_script( 'wporg-developer-user-notes-voting' );
@@ -307 +307 @@
         }
 
-        echo '<div id="user-note-voting" class="user-note-voting" data-nonce="' . esc_attr( $nonce ) . '">';
+        echo '<div class="user-note-voting" data-nonce="' . esc_attr( $nonce ) . '">';
 
         // Up vote link
@@ -333 +333 @@
         }
         echo '">';
-        echo '<span class="dashicons dashicons-arrow-up"></span>';
+        echo '<span class="dashicons dashicons-arrow-up" aria-hidden="true"></span>';
         echo '<span class="screen-reader-text">' . $title .  '</span>';
         echo "</{$tag}>";
@@ -374 +374 @@
         }
         echo '">';
-        echo '<span class="dashicons dashicons-arrow-down"></span>';
+        echo '<span class="dashicons dashicons-arrow-down" aria-hidden="true"></span>';
         echo '<span class="screen-reader-text">' . $title .  '</span>';
         echo "</{$tag}>";

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/js/user-notes-voting.js

@@ -5 +5 @@
 
 ( function( $, wp ) {
-    $( '#user-note-voting' ).on( 'click', '.user-note-voting-up, .user-note-voting-down', function( event ) {
+    $( '#comments' ).on( 'click', 'a.user-note-voting-up, a.user-note-voting-down', function( event ) {
         event.preventDefault();