Changeset 7304 for sites/trunk/wordpress.org/public_html/wp-content/plugins/official-wordpress-events/official-wordpress-events.php

Timestamp:

06/13/2018 07:38:35 PM (8 years ago)

Author:

coreymckrill

Message:

Official WordPress Events: Changes to Meetup API interface

The Meetup API is sporadically throwing back a 400 error on seemingly valid
requests. The changes here attempt to avoid these errors by using some of the
same strategies as WordCamp's Meetup API Client:

• Re-sign every URL during a multi-page request
• Chunk the group IDs into smaller batches

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/official-wordpress-events/official-wordpress-events.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/official-wordpress-events/official-wordpress-events.php

@@ -322 +322 @@
                 }
 
-                $groups = array_chunk( $groups, 200, true );
+                // Meetup API sometimes throws an error with chunk size larger than 50.
+                $groups = array_chunk( $groups, 50, true );
 
                 foreach ( $groups as $group_batch ) {
-                        $request_url = sprintf(
-                                '%s2/events?group_id=%s&time=0,3m&page=%d&key=%s&status=upcoming,cancelled',
-                                self::MEETUP_API_BASE_URL,
-                                implode( ',', $group_batch ),
-                                200,
-                                MEETUP_API_KEY
+                        $request_url = add_query_arg(
+                                array(
+                                        'group_id' => implode( ',', $group_batch ),
+                                        'time'     => '0,3m',
+                                        'page'     => 200,
+                                        'status'   => 'upcoming,cancelled',
+                                ),
+                                self::MEETUP_API_BASE_URL . '2/events'
                         );
 
                         while ( ! empty( $request_url ) ) {
+                                // The "next" URLs returned by the API need to be re-signed.
+                                $request_url = add_query_arg(
+                                        array(
+                                                'sign' => true,
+                                                'key'  => MEETUP_API_KEY,
+                                        ),
+                                        $request_url
+                                );
+
                                 $this->log( 'fetching more events from: ' . var_export( $request_url, true ) );