Changeset 7314

Timestamp:

06/16/2018 10:23:32 AM (6 years ago)

Author:

ocean90

Message:

Translate, Custom Warnings: Add a whitelist for the last URL character to reduce the number of false-positives for mismatching URLs.

Fixes #1401.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-custom-warnings/wporg-gp-custom-warnings.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-custom-warnings/wporg-gp-custom-warnings.php

@@ -34 +34 @@
      */
     public function warning_mismatching_urls( $original, $translation ) {
-        // Any http/https/schemeless URLs which are not encased in quotation marks nor contain whitespace
-        $urls_regex = '@(?<![\'"])((https?://|(?<![:\w])//)[^\s]+)(?![\'"])@i';
+        // Any http/https/schemeless URLs which are not encased in quotation marks
+        // nor contain whitespace and end with a valid URL ending char.
+        $urls_regex = '@(?<![\'"])((https?://|(?<![:\w])//)[^\s]+[a-z0-9\-_&=#/])(?![\'"])@i';
 
         preg_match_all( $urls_regex, $original, $original_urls );