Changeset 7350 for sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-main/page-about-testimonials.php

Timestamp:

06/29/2018 08:57:02 PM (8 years ago)

Author:

obenland

Message:

Main: phpcs updates

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-main/page-about-testimonials.php (modified) (6 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-main/page-about-testimonials.php

@@ -7 +7 @@
  * @package WordPressdotorg\MainTheme
  */
+
+// phpcs:disable WordPress.VIP.RestrictedFunctions
 
 namespace WordPressdotorg\MainTheme;
@@ -23 +25 @@
 } );
 
-// See inc/page-meta-descriptions.php for the meta description for this page.
+/* See inc/page-meta-descriptions.php for the meta description for this page. */
 
-// Pull list of testimonial URLs from the news page holding them
+// Pull list of testimonial URLs from the news page holding them.
 switch_to_blog( 8 );
-$testpage = get_page_by_path( 'testimonials' );
+$testimonials_post = get_page_by_path( 'testimonials' );
 restore_current_blog();
 
-// we only need the URLs in the post_content
-preg_match_all( '|https://\S+|', $testpage->post_content, $testimonials );
-$testimonials = $testimonials[0];
+if ( $testimonials_post instanceof \WP_Post ) {
+        // We only need the URLs in the post_content.
+        preg_match_all( '|https://\S+|', $testimonials_post->post_content, $testimonials );
+        $testimonials = $testimonials[0];
+} else {
+        $testimonials = [];
+}
 
-// separate out the twiiter from the WPs
-$embed_tweets = array_values( array_filter( $testimonials, function ($t) { return strpos( $t, 'https://twitter.com' ) === 0; } ) );
-$embed_wps    = array_values( array_filter( $testimonials, function ($t) { return strpos( $t, 'https://twitter.com' ) !== 0; } ) );
+// Separate out the twitter from the WPs.
+$embed_tweets = array_values( array_filter( $testimonials, function( $t ) {
+        return strpos( $t, 'https://twitter.com' ) === 0;
+} ) );
+$embed_wps = array_values( array_filter( $testimonials, function( $t ) {
+        return strpos( $t, 'https://twitter.com' ) !== 0;
+} ) );
 
-// Randomize the tweet order
+// Randomize the tweet order.
 shuffle( $embed_tweets );
 
-// Strip out everything but the Tweet ID
+// Strip out everything but the Tweet ID.
 array_walk( $embed_tweets, function ( &$tweet ) {
         $tweet = preg_replace( '|https?://twitter.com/.*/status/([0-9]+)|', '$1', $tweet );
@@ -70 +80 @@
                                 conversation: 'none',
                                 cards: 'hidden',
-                                margin: 0, width: 372
+                                margin: 0, 
+                                width: 372
                         }
                 ).then( function() {
@@ -92 +103 @@
 wp_add_inline_script( 'twitter-widgets', $custom_js );
 wp_localize_script( 'twitter-widgets', 'embeds', array(
-        'tweets' => $embed_tweets,
+        'tweets'   => $embed_tweets,
         'wpembeds' => $embed_wps,
 ) );
@@ -107 +118 @@
 
                         <div class="entry-content row">
-
                                 <section class="col-8">
-                                        <h3><?php _e( 'Share your WordPress story', 'wporg' ); ?></h3>
-
-                                        <p><?php _e( 'Want to have your story featured on this page?', 'wporg' ); ?></p>
-
-                                        <p><?php
+                                        <h3><?php esc_html_e( 'Share your WordPress story', 'wporg' ); ?></h3>
+                                        <p><?php esc_html_e( 'Want to have your story featured on this page?', 'wporg' ); ?></p>
+                                        <p>
+                                                <?php
                                                 /* translators: Link to the twitter #ilovewp feed */
-                                                printf( __( "Make a blog post with your story and tweet a link to it using the <a href='%s'>#ilovewp</a> hashtag. We'll select the best ones and feature them here!", 'wporg' ), 'https://twitter.com/search?q=%23ilovewp' );
-                                        ?></p>
+                                                printf( wp_kses_post( __( 'Make a blog post with your story and tweet a link to it using the <a href="%s">#ilovewp</a> hashtag. We&#8217;ll select the best ones and feature them here!', 'wporg' ) ), 'https://twitter.com/search?q=%23ilovewp' );
+                                                ?>
+                                        </p>
 
                                         <p>
@@ -126 +136 @@
                                                 </a>
                                         </p>
-
                                 </section>
 
-                                <section class="col-10" id="embeds">
-                                </section>
+                                <section class="col-10" id="embeds"></section>
                         </div><!-- .entry-content -->
-
                 </article><!-- #post-## -->