Changeset 7415

Timestamp:

07/10/2018 10:58:38 PM (6 years ago)

Author:

obenland

Message:

Plugins: Prevent BANNED users from getting plugin commit

Props dryanpress.
Fixes #3700.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory

Files:

• admin/metabox/class-committers.php (modified) (1 diff)
• api/routes/class-plugin-committers.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-committers.php

@@ -59 +59 @@
         }
 
+        if ( ! empty( $committer->allcaps['bbp_blocked'] ) ) {
+            $response->add( array(
+                'what' => 'committer',
+                'data' => new \WP_Error( 'error', sprintf( __( 'The user %s is banned/blocked.', 'wporg-plugins' ), '<code>' . $login . '</code>' ) ),
+            ) );
+            $response->send();
+        }
+
         $result = Tools::grant_plugin_committer( $post->post_name, $committer );
 

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-plugin-committers.php

@@ -108 +108 @@
         }
 
+        if ( ! empty( $user->allcaps['bbp_blocked'] ) ) {
+            return new WP_Error( 'plugin_user_banned', __( 'User is blocked/banned and cannot be granted commmit.', 'wporg-plugins' ) );
+        }
+
         $plugin_slug = $request['plugin_slug'];