Changeset 7441

Timestamp:

07/12/2018 06:36:54 PM (7 years ago)

Author:

coffee2code

Message:

developer.wordpress.org: Prevent unintended override of 'is_handbook_root' property.

Fixes #3708.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook/handbook.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook/handbook.php

@@ -331 +331 @@
 
     function pre_get_posts( $query ) {
+        // Bail early if query is not for this handbook's post type.
+        if ( get_query_var( 'post_type' ) !== $this->post_type ) {
+            // Request is obviously not for a handbook root page. (Though if the request is
+            // for some other handbook's root page will be determined by that handbook.)
+            if ( empty( get_query_var( 'handbook' ) ) ) {
+                $query->is_handbook_root = false;
+            }
+            return;
+        }
+
         $query->is_handbook_root = false;