Changeset 7488

Timestamp:

07/20/2018 09:02:49 PM (7 years ago)

Author:

coreymckrill

Message:

WordCamp Payments: Update access to budget tools

This makes parts of the budget tools available to other users besides Admins
on a WordCamp site.

Authors and Editors can:

• View the preliminary and working budgets, but cannot save changes or submit for review.
• Create sponsor invoices, reimbursement requests, and vendor payment requests, but cannot view/change items of these types that were created by other users.

Admins still have all the same capabilities as before, and do not have the
restrictions detailed above that Authors and Editors have.

Location:

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments

Files:

• includes/budget-tool.php (modified) (1 diff)
• includes/wordcamp-budgets.php (modified) (2 diffs)
• views/budget-tool/main.php (modified) (2 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/budget-tool.php

@@ -9 +9 @@
 
     public static function admin_menu() {
-        add_submenu_page( 'wordcamp-budget', esc_html__( 'WordCamp Budget', 'wordcamporg' ), esc_html__( 'Budget', 'wordcamporg' ), 'manage_options', 'wordcamp-budget' );
+        add_submenu_page(
+            'wordcamp-budget',
+            esc_html__( 'WordCamp Budget', 'wordcamporg' ),
+            esc_html__( 'Budget', 'wordcamporg' ),
+            WordCamp_Budgets::VIEWER_CAP,
+            'wordcamp-budget'
+        );
+
+        register_setting(
+            'wcb_budget_noop',
+            'wcb_budget_noop',
+            array( __CLASS__, 'validate' )
+        );
+
         add_action( 'wcb_render_budget_page', array( __CLASS__, 'render' ) );
-        register_setting( 'wcb_budget_noop', 'wcb_budget_noop', array( __CLASS__, 'validate' ) );
     }
 
     public static function validate( $noop ) {
-        if ( empty( $_POST['_wcb_budget_data'] ) )
-            return;
-
-        if ( empty( $_REQUEST['_wpnonce'] ) || ! wp_verify_nonce( $_REQUEST['_wpnonce'], 'wcb_budget_noop-options' ) )
-            return;
+        if ( empty( $_POST['_wcb_budget_data'] ) ) {
+            return;
+        }
+
+        if ( empty( $_REQUEST['_wpnonce'] ) || ! wp_verify_nonce( $_REQUEST['_wpnonce'], 'wcb_budget_noop-options' ) ) {
+            return;
+        }
+
+        if ( ! current_user_can( WordCamp_Budgets::ADMIN_CAP ) ) {
+            return;
+        }
 
         $budget = self::_get_budget();

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/wordcamp-budgets.php

@@ -7 +7 @@
     const VERSION = '0.1.4';
     const PAYMENT_INFO_RETENTION_PERIOD = 7; // days
+
+    const VIEWER_CAP = 'publish_posts';
+    const ADMIN_CAP  = 'manage_options';
 
     /**
@@ -114 +117 @@
             esc_html__( 'WordCamp Budget', 'wordcamporg' ),
             esc_html__( 'Budget',          'wordcamporg' ),
-            'manage_options',
+            self::VIEWER_CAP,
             'wordcamp-budget',
             function() { do_action( 'wcb_render_budget_page' ); },

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/views/budget-tool/main.php

@@ -108 +108 @@
         <input type="hidden" name="_wcb_budget_data" value="<?php echo esc_attr( json_encode( $budget ) ); ?>" />
 
-        <?php if ( $budget['status'] == 'draft' ) : ?>
+        <?php if ( $budget['status'] == 'draft' && current_user_can( WordCamp_Budgets::ADMIN_CAP ) ) : ?>
         <p class="submit">
             <?php submit_button( esc_html__( 'Save Draft', 'wordcamporg' ), 'secondary', 'wcb-budget-save-draft', false ); ?>
@@ -120 +120 @@
             <?php submit_button( esc_html__( 'Reject', 'wordcamporg' ), 'primary', 'wcb-budget-reject', false ); ?>
         </p>
-        <?php elseif ( $budget['status'] == 'approved' && $view == 'working' ) : ?>
+        <?php elseif ( $budget['status'] == 'approved' && $view == 'working' && current_user_can( WordCamp_Budgets::ADMIN_CAP ) ) : ?>
         <p class="submit">
             <?php submit_button( esc_html__( 'Update Working Budget', 'wordcamporg' ), 'primary', 'wcb-budget-update-working', false ); ?>