Changeset 7629 for sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-wordcamp/wordcamp-admin.php

Timestamp:

08/23/2018 09:47:59 PM (6 years ago)

Author:

vedjain

Message:

WordCamp: Added list of original values wcpt_metabox_save_done do_action so that any callback can use original values to see if anything is changed.
Also make use of original values in update_venue_address and fix a bug where it was always returning early because $new_address has already just been saved to the post meta.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-wordcamp/wordcamp-admin.php (modified) (3 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-wordcamp/wordcamp-admin.php

@@ -56 +56 @@
             add_action( 'plugins_loaded', array( $this, 'schedule_cron_jobs' ), 11 );
             add_action( 'wcpt_close_wordcamps_after_event', array( $this, 'close_wordcamps_after_event' ) );
-            add_action( 'wcpt_metabox_save_done', array( $this, 'update_venue_address' ) );
+            add_action( 'wcpt_metabox_save_done', array( $this, 'update_venue_address' ), 10, 2 );
             add_action( 'wcpt_metabox_save_done', array( $this, 'update_mentor' ) );
         }
@@ -152 +152 @@
          * These are used for the maps on Central, stats, etc.
          *
-         * @param int $post_id Post id
-         */
-        public function update_venue_address( $post_id ) {
+         * @param int   $post_id              Post id
+         * @param array $original_meta_values Original meta values before save
+         */
+        public function update_venue_address( $post_id, $original_meta_values ) {
             if ( $this->get_event_type() !== get_post_type() ) {
                 return;
@@ -161 +162 @@
             // If the venue address was changed, update its coordinates
             $new_address = $_POST[ wcpt_key_to_str( 'Physical Address', 'wcpt_' ) ];
-            if ( $new_address === get_post_meta( $post_id, 'Physical Address', true ) ) {
+            if ( $new_address === $original_meta_values['Physical Address'] ) {
                 return;
             }