Making WordPress.org


Ignore:
Timestamp:
09/12/2018 05:15:50 AM (6 years ago)
Author:
dd32
Message:

Slack: Update the Announce whitelists to consistently use WordPress.org usernames rather than non-unique deprecated slack user_names.

See #3799.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • sites/trunk/common/includes/slack/announce/lib.php

    r7662 r7663  
    8585
    8686    if ( $data['command'] === '/committers' ) {
     87        // This command seems to not be used actively, in preference for the slack @committers group pings.
    8788        $committers = get_committers();
    8889        if ( ! in_array( $user, $committers, true ) ) {
     
    9091        }
    9192
     93        // TODO: Note that pinging users by `@username` is deprecated, and we now have WordPress.org usernames in the above list.
     94        // This should be upadted to ping users by the `<@U.....>` format.
     95
    9296        $text = sprintf( "*@committers:* %s\n_(cc: %s)_", $data['text'], '@' . implode( ', @', $committers ) );
    9397    } elseif ( $data['command'] === '/deputies' ) {
    94         // This is not all deputies; it's only the ones who want to receive `/deputies` pings
    95         $pingable_deputies = array(
    96             '00sleepy', '_dorsvenabili', 'adityakane', 'andreamiddleton', 'bph', 'brandondove', 'camikaos',
    97             'chanthaboune', 'courtneypk', 'drebbits', 'francina', 'gounder', 'heysherie', 'hlashbrooke',
    98             'karenalma', 'kcristiano', 'kdrewien', 'kenshino', 'mayukojpn', 'mikelking', 'miss_jwo',
    99             'remediosgraphic', 'savione', 'vc27', 'yaycheryl',
    100         );
    101         $pingable_deputies = array( 'coreymckrill', 'iandunn' ); // todo remove after testing
     98        $pingable_deputies = get_pingable_worcamp_deputies();
    10299
    103100        if ( ! in_array( $user, $pingable_deputies, true ) ) {
    104101            return;
    105102        }
     103
     104        // TODO: Note that pinging users by `@username` is deprecated, and we have WordPress.org usernames in the above list.
     105        // This should be upadted to ping users by the `<@U.....>` format.
    106106
    107107        $text = sprintf( "*/deputies:* %s\n_(CC: %s)_", $data['text'], '@' . implode( ', @', $pingable_deputies ) );
Note: See TracChangeset for help on using the changeset viewer.