Changeset 7664

Timestamp:

09/12/2018 06:02:09 AM (8 years ago)

Author:

dd32

Message:

Trac Notifications: Properly encode Component names in urls.

H/t SergeyBiryukov.
Fixes #3761.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/trac-notifications/trac-components.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/trac-notifications/trac-components.php

@@ -630 +630 @@
                         $focuses = array( 'accessibility', 'administration', 'coding-standards', 'docs', 'javascript', 'multisite', 'performance', 'privacy', 'rest-api', 'rtl', 'template', 'ui' );
                         foreach ( $focuses as $focus ) {
-                                echo '<option value="focus/' . $focus . '">' . $focus . ( $both ? ' (focus)' : '' ) . '</option>';
+                                echo '<option value="focus/' . esc_attr( rawurlencode( $focus ) ) . '">' . $focus . ( $both ? ' (focus)' : '' ) . '</option>';
                         }
                 }
@@ -639 +639 @@
                         $components = $this->api->get_components();
                         foreach ( $components as $component ) {
-                                echo '<option value="component/' . esc_attr( str_replace( ' ', '+', $component ) ) . '">' . esc_html( $component ) . "</option>";
+                                echo '<option value="component/' . esc_attr( rawurlencode( $component ) ) . '">' . esc_html( $component ) . "</option>";
                         }
                 }
@@ -678 +678 @@
                         $open_tickets = array_sum( $this->breakdown_component_type[ $component ] );
                 }
-                echo '<td class="right"><a href="https://core.trac.wordpress.org/component/' . esc_attr( str_replace( ' ', '+', $component ) ) . '">' . $open_tickets . '</a></td>';
+                echo '<td class="right"><a href="https://core.trac.wordpress.org/component/' . esc_attr( rawurlencode( $component ) ) . '">' . $open_tickets . '</a></td>';
                 if ( $history['change'] ) {
                         $count = sprintf( "%+d", $history['change'] );