Changeset 7711 for sites/trunk/browsehappy.com/public_html/functions.php

Timestamp:

10/01/2018 08:29:33 PM (6 years ago)

Author:

coffee2code

Message:

Browse Happy: Add fallback to prevent latest browser version number from not being shown.

Doing a WikiQuery ranking based on wikibase:PreferredRank can fail to return a result if no version was marked as preferred, which can sometimes happen. In such cases, rerun the query but rank based on wikibase:NormalRank with no limits and sort result to determine the latest version.

See ​https://github.com/WordPress/browsehappy/issues/48.

File:

• sites/trunk/browsehappy.com/public_html/functions.php (modified) (4 diffs)

sites/trunk/browsehappy.com/public_html/functions.php

@@ -84 +84 @@
 }
 
-function browsehappy_fetch_version( $browser, $normalize = true ) {
+function browsehappy_fetch_version( $browser, $normalize = true, $rank = true ) {
 
     $fragment = browsehappy_get_browser_data( $browser )->wikidata;
@@ -100 +100 @@
     }
 
+    $rank_type = $rank ? 'PreferredRank' : 'NormalRank';
+    $limit     = $rank ? 'LIMIT 1' : '';
+
     // See https://github.com/WordPress/browsehappy/issues/37
     $query = "
@@ -105 +108 @@
             wd:{$fragment} p:P348 [
                 ps:P348 ?version;
-                wikibase:rank wikibase:PreferredRank
+                wikibase:rank wikibase:{$rank_type}
             ].
         }
-        LIMIT 1
+        {$limit}
     ";
 
@@ -128 +131 @@
         empty( $data ) ||
         empty( $data->results ) ||
-        ! is_array( $data->results->bindings ) ||
+        ! is_array( $data->results->bindings )
+    ) {
+        return false;
+    }
+
+    if (
         empty( $data->results->bindings[0] ) ||
         empty( $data->results->bindings[0]->version ) ||
         empty( $data->results->bindings[0]->version->value )
     ) {
-        return false;
+        if ( $rank ) {
+            return browsehappy_fetch_version( $browser, $normalize, false );
+        } else {
+            return false;
+        }
+    }
+
+    if ( ! $rank ) {
+        usort( $data->results->bindings, function( $a, $b ) {
+            return strcmp( $b->version->value, $a->version->value );
+        } );
     }