Changeset 7723

Timestamp:

10/11/2018 09:56:14 PM (7 years ago)

Author:

coffee2code

Message:

Handbook plugin: Add greater specificity to cache key to prevent cached posts from being used in the wrong context.

Fixes bug where navigation links often didn't appear.

See #3757.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook/inc/navigation.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook/inc/navigation.php

@@ -163 +163 @@
         }
 
-        // Cache key format is pages:{post type}:{sort column}(:{excluded})?.
-        $cache_key = 'pages:' . get_post_type( $post ) . ':' . $sort_column;
+        // Cache key format is pages:{post ID}:{sort column}:{source_post}(:{excluded})?.
+        $cache_key = 'pages:' . $post->ID . ':' . $sort_column . ':' . ( $source_post ? '1' : '0' );
         if ( $exclude ) {
             $cache_key .= ':' . str_replace( ' ', '', $exclude );