Changeset 773

Timestamp:

07/30/2014 10:08:42 PM (11 years ago)

Author:

coffee2code

Message:

Code Reference: fixes for, and selective activation of, handbooks

• Landing page:
  • Permit members of site to access the page
  • Set proper links to handbooks
  • Don't display the page content
• Redirect naked '/handbook/' requests to home page
• Remove 'Handbook' from handbook breadcrumbs
• Base site section title for handbooks on is_post_type_archive()

Location:

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer

Files:

• functions.php (modified) (4 diffs)
• inc/template-tags.php (modified) (1 diff)
• page-home-landing.php (modified) (4 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/functions.php

@@ -49 +49 @@
     add_action( 'pre_get_posts', __NAMESPACE__ . '\\pre_get_posts' );
     add_action( 'template_redirect', __NAMESPACE__ . '\\redirect_single_search_match' );
+    add_action( 'template_redirect', __NAMESPACE__ . '\\redirect_handbook' );
     add_action( 'wp_enqueue_scripts', __NAMESPACE__ . '\\theme_scripts_styles' );
     add_filter( 'post_type_link', __NAMESPACE__ . '\\method_permalink', 10, 2 );
@@ -63 +64 @@
 
     add_filter( 'breadcrumb_trail_items',  __NAMESPACE__ . '\\breadcrumb_trail_items', 10, 2 );
+    add_filter( 'breadcrumb_trail_items',  __NAMESPACE__ . '\\breadcrumb_trail_remove_handbook', 10, 2 );
 
     treat_comments_as_examples();
@@ -94 +96 @@
     // Unset the last element since it shifted up in trail hierarchy
     unset( $items[4] );
+
+    return $items;
+}
+
+/**
+ * Removes the 'Handbook' segment of the breakcrumb, when present.
+ *
+ * There is no handbook page or listing at present.
+ *
+ * @param  array $items The breadcrumb trail items
+ * @param  array $args  Original arg
+ * @return array
+ */
+function breadcrumb_trail_remove_handbook( $items, $args ) {
+    if ( false !== strpos( $items[1], '>Handbook</a>' ) ) {
+        array_splice( $items, 1, 1 );
+    }
 
     return $items;
@@ -474 +493 @@
 
 /**
+ * Redirects a naked handbook request to home.
+ */
+function redirect_handbook() {
+    if ( 'handbook' == get_query_var( 'name' ) && ! get_query_var( 'post_type ' ) ) {
+        wp_redirect( home_url() );
+        exit();
+    }
+}
+
+/**
  * Makes phpDoc @link references clickable.
  *

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/template-tags.php

@@ -336 +336 @@
      */
     function get_site_section_title() {
+        if ( is_post_type_archive( array( 'plugin-handbook' ) ) ) {
+            return __( 'Plugin Handbook', 'wporg' );
+        }
+
+        if ( is_post_type_archive( array ( 'theme-handbook' ) ) ) {
+            return __( 'Theme Handbook', 'wporg' );
+        }
+
         $parts = explode( '/', $_SERVER['REQUEST_URI'] );
         switch ( $parts[1] ) {
             case 'reference':
-                return 'Code Reference';
-            case 'theme-handbook':
-                return 'Theme Handbook';
-            case 'plugin-handbook':
-                return 'Plugin Handbook';
+                return __( 'Code Reference', 'wporg' );
             default:
-                return 'Developer Resources';
+                return __( 'Developer Resources', 'wporg' );
         }
     }

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/page-home-landing.php

@@ -9 +9 @@
 
 // Temporarily redirect to reference until other section become live, justifying a main landing page.
-wp_redirect( get_permalink( get_page_by_path( 'reference' ) ) );
-exit();
+if ( ! is_user_member_of_blog() ) {
+    wp_redirect( get_permalink( get_page_by_path( 'reference' ) ) );
+    exit();
+}
 
 get_header(); ?>
@@ -23 +25 @@
                         <h3 class="widget-title"><div class="dashicons dashicons-welcome-widgets-menus"></div><?php _e( 'Themes', 'wporg' ); ?></h3>
                         <p class="widget-description"><?php _e( 'Want to know all there is to know about theming and WordPress?', 'wporg' ); ?></p>
-                        <a href="#" class="themes-go get-started go button"><?php _e( 'Develop Themes ', 'wporg' ); ?><span class="dashicons dashicons-arrow-right-alt2"></span></a>
+                        <a href="<?php esc_attr_e( get_post_type_archive_link( 'theme-handbook' ) ); ?>" class="themes-go get-started go button"><?php _e( 'Develop Themes ', 'wporg' ); ?><span class="dashicons dashicons-arrow-right-alt2"></span></a>
                     </div>
                     <div class="widget box box-right transparent">
                         <h3 class="widget-title"><div class="dashicons dashicons-admin-plugins"></div><?php _e( 'Plugins', 'wporg' ); ?></h3>
                         <p class="widget-description"><?php _e( 'Ready to dive deep into the world of plugin authoring?', 'wporg' ); ?></p>
-                        <a href="#" class="plugins-go get-started go button"><?php _e( 'Develop Plugins ', 'wporg' ); ?><span class="dashicons dashicons-arrow-right-alt2"></span></a>
+                        <a href="<?php esc_attr_e( get_post_type_archive_link( 'plugin-handbook' ) ); ?>" class="plugins-go get-started go button"><?php _e( 'Develop Plugins ', 'wporg' ); ?><span class="dashicons dashicons-arrow-right-alt2"></span></a>
                     </div>
                 </div>
@@ -47 +49 @@
             </div><!-- /new-in-guide -->
 
-
+<?php /*
             <main id="main" class="site-main section" role="main">
 
@@ -72 +74 @@
 
             </main><!-- #main -->
-
+*/ ?>
 
             <div class="search-guide section light-gray clear">