Changeset 7750

Timestamp:

10/19/2018 08:06:43 PM (6 years ago)

Author:

iandunn

Message:

Meetup Client: Retry misleading 200 responses with empty bodies.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/utilities/class-meetup-client.php (modified) (4 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/utilities/class-meetup-client.php

@@ -84 +84 @@
                     $this->error->add(
                         'unexpected_response_data',
-                        'The API response did not provide the expected data format.'
+                        'The API response did not provide the expected data format.',
+                        $response
                     );
                     break;
@@ -169 +170 @@
          * See https://www.meetup.com/meetup_api/docs/#errors.
          *
+         * `200` (ok) is not in the list, because it needs to be handled conditionally. See below.
+         *
          * `400` (bad request) is not in the list, even though it seems like it _should_ indicate an unrecoverable
          * error. In practice we've observed that it's common for a seemingly valid request to be rejected with
@@ -174 +177 @@
          */
         $breaking_codes = array(
-            200, // Ok.
             401, // Unauthorized (invalid key).
             429, // Too many requests (rate-limited).
@@ -190 +192 @@
 
             $this->maybe_throttle( wp_remote_retrieve_headers( $response ) );
+
+            /*
+             * Sometimes their API inexplicably returns a success code with an empty body, but will return a valid
+             * response if the exact request is retried.
+             */
+            if ( 200 === $response_code && ! empty( wp_remote_retrieve_body( $response ) ) ) {
+                break;
+            }
 
             if ( in_array( $response_code, $breaking_codes, true ) ) {