Changeset 7762

Timestamp:

10/23/2018 05:04:37 PM (7 years ago)

Author:

coffee2code

Message:

developer.wordpress.org: Improve JS by only searching for comments once.

Props keesiemeijer.
Fixes #3882.

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/js/user-notes-feedback.js (modified) (7 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/js/user-notes-feedback.js

@@ -7 +7 @@
     var wpAdminBar     = 0;
     var options        = wporg_note_feedback;
+    var comments       = $( '.comment' );
     var feedbackToggle = $( '<a role="button" class="feedback-toggle" href="#">' + options.show + '</a>' );
     var commentID      = window.location.hash;
@@ -28 +29 @@
 
     // Loop through feedback notes
-    $( '.comment' ).each( function() {
+    comments.each( function() {
         var feedbackLinks = $( this ).find( '.feedback-links' );
         var childComments = $( this ).find( 'ul.children' );
@@ -86 +87 @@
         // Set wpAdminBar
         wpAdminBar = $('#wpadminbar').length ? 32 : 0;
-        var childComments = $( '.comment' ).find( 'ul.children' );
+        var childComments = comments.find( 'ul.children' );
 
         if ( ! ( commentID.length && childComments.length ) ) {
@@ -92 +93 @@
         }
 
-        var comment = childComments.find( commentID + '.depth-2' ).first();
-        if ( ! comment.length ) {
+        var childComment = childComments.find( commentID + '.depth-2' ).first();
+        if ( ! childComment.length ) {
             return;
         }
         // Child comment exists.
 
-        var parent = comment.closest( '.comment.depth-1' );
+        var parent = childComment.closest( '.comment.depth-1' );
         if ( parent.find( '.feedback' ).hasClass( 'hide-if-js' ) ) {
             // Show child comments.
@@ -105 +106 @@
 
         // Scroll to child comment and adjust for admin bar
-        var pos = comment.offset();
+        var pos = childComment.offset();
         $( 'html,body' ).animate( {
             scrollTop: pos.top - wpAdminBar
@@ -113 +114 @@
 
     // Click event for Show/Hide feedback toggle link.
-    $( document ).on( 'click', '.feedback-toggle', function( e ) {
+    comments.on( 'click', '.feedback-toggle', function( e ) {
         e.preventDefault();
 
@@ -161 +162 @@
 
     // Show editor when the add feedback link is clicked.
-    $( document ).on( 'click', '.feedback-add', function( e ) {
+    comments.on( 'click', '.feedback-add', function( e ) {
         e.preventDefault();