Changeset 7815 for sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/explanations.php

Timestamp:

11/01/2018 08:40:23 PM (7 years ago)

Author:

coffee2code

Message:

Developer: Centralize enqueuing of admin stylesheet.

Adds helper get_parsed_post_types_screen_ids().

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/explanations.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/explanations.php

@@ -61 +61 @@
 
         // Script and styles.
+        add_filter( 'devhub-admin_enqueue_scripts', array( $this, 'admin_enqueue_base_scripts' ) );
         add_action( 'admin_enqueue_scripts',   array( $this, 'admin_enqueue_scripts'  )        );
 
@@ -441 +442 @@
 
     /**
+     * Enables enqueuing of admin.css for explanation pages.
+     *
+     * @access public
+     *
+     * @param bool $do_enqueue Should admin.css be enqueued?
+     * @return bool True if admin.css should be enqueued, false otherwise.
+     */
+    public function admin_enqueue_base_scripts( $do_enqueue ) {
+        return $do_enqueue || in_array( get_current_screen()->id, $this->screen_ids  );
+    }
+
+    /**
      * Enqueue JS and CSS for all parsed post types and explanation pages.
      *
@@ -447 +460 @@
     public function admin_enqueue_scripts() {
 
-        $parsed_post_types = array();
-
-        foreach ( \DevHub\get_parsed_post_types() as $post_type ) {
-            $parsed_post_types[] = $post_type;
-            $parsed_post_types[] = "edit-{$post_type}";
-        }
+        $parsed_post_types_screen_ids = DevHub_Admin::get_parsed_post_types_screen_ids();
 
         if ( in_array( get_current_screen()->id, array_merge(
-                $parsed_post_types,
+                $parsed_post_types_screen_ids,
                 $this->screen_ids
         ) ) ) {
-            wp_enqueue_style( 'wporg-admin', get_template_directory_uri() . '/stylesheets/admin.css', array(), '20160630' );
             wp_enqueue_script( 'wporg-explanations', get_template_directory_uri() . '/js/explanations.js', array( 'jquery', 'wp-util' ), '20160630', true );