Changeset 785

Timestamp:

08/12/2014 06:37:14 AM (10 years ago)

Author:

coffee2code

Message:

Code Reference: fix section titles and links

• Add get_site_section_url() to get appropriate section home URL
• Fix get_site_section_title() for plugin and theme handbooks
• Condense markup creation

Location:

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer

Files:

• header.php (modified) (1 diff)
• inc/template-tags.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/header.php

@@ -18 +18 @@
         <div class="inner-wrap">
             <div class="site-branding">
-                <?php if ( ! is_front_page() ) : ?>
-                    <h1 class="site-title"><a href="<?php echo esc_url( home_url( '/reference/' ) ); ?>" rel="home"><?php echo DevHub\get_site_section_title(); ?></a></h1>
-                <?php else : ?>
-                    <span class="site-title"><a href="<?php echo esc_url( home_url( '/' ) ); ?>" rel="home"><?php echo DevHub\get_site_section_title(); ?></a></span>
-                <?php endif; ?>
+                <?php $tag = is_front_page() ? 'span' : 'h1'; ?>
+                <<?php echo $tag; ?> class="site-title">
+                    <a href="<?php echo esc_url( DevHub\get_site_section_url() ); ?>" rel="home"><?php echo DevHub\get_site_section_title(); ?></a>
+                </<?php echo $tag; ?>>
             </div>
         </div><!-- .inner-wrap -->

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/template-tags.php

@@ -331 +331 @@
 
     /**
-     * Get site section from url path
+     * Get site section root URL based on URL path.
+     *
+     * @return string
+     */
+    function get_site_section_url() {
+        $parts = explode( '/', $_SERVER['REQUEST_URI'] );
+        switch ( $parts[1] ) {
+            case 'reference':
+            case 'plugin':
+            case 'theme':
+                return home_url( '/' . $parts[1] . '/' );
+            default:
+                return home_url( '/' );
+        }
+    }
+
+    /**
+     * Get site section title based on URL path.
      *
      * @return string
      */
     function get_site_section_title() {
-        if ( is_post_type_archive( array( 'plugin-handbook' ) ) ) {
-            return __( 'Plugin Handbook', 'wporg' );
-        }
-
-        if ( is_post_type_archive( array ( 'theme-handbook' ) ) ) {
-            return __( 'Theme Handbook', 'wporg' );
-        }
-
         $parts = explode( '/', $_SERVER['REQUEST_URI'] );
         switch ( $parts[1] ) {
             case 'reference':
                 return __( 'Code Reference', 'wporg' );
+            case 'plugin':
+                return __( 'Plugin Handbook', 'wporg' );
+            case 'theme':
+                return __( 'Theme Handbook', 'wporg' );
             default:
                 return __( 'Developer Resources', 'wporg' );