Changeset 7909

Timestamp:

11/27/2018 08:28:49 PM (8 years ago)

Author:

coreymckrill

Message:

WordCamp Genderize client: Apply coding standards, improve readability

File:

• sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/utilities/class-genderize-client.php (modified) (5 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/utilities/class-genderize-client.php

@@ -13 +13 @@
  */
 class Genderize_Client extends API_Client {
-
+        /**
+         * @var string The option key where the cache is saved in the database.
+         */
         const CACHE_KEY = 'genderize_cached_data';
 
@@ -70 +72 @@
 
                 if ( true === $this->options->reset_cache ) {
-                        $this->cache = [];
-                        $this->save_cached_data();
+                        delete_option( self::CACHE_KEY );
                 }
         }
@@ -84 +85 @@
          */
         public function get_gender_data( array $names, $locale ) {
+                $names     = array_unique( array_map( 'strtolower', $names ) );
+                $lang_code = $this->get_lang_code_from_locale( $locale );
+
                 // Bail if there are errors.
                 if ( ! empty( $this->error->get_error_messages() ) ) {
@@ -91 +95 @@
                 $data         = [];
                 $needs_update = [];
-
-                $names     = array_unique( array_map( 'strtolower', $names ) );
-                $lang_code = $this->get_lang_code_from_locale( $locale );
 
                 foreach ( $names as $name ) {
@@ -173 +174 @@
                 }
 
-                return $cache[ $lang_code ][ $name ];
+                return $item;
         }