Changeset 7925

Timestamp:

12/03/2018 02:54:35 AM (6 years ago)

Author:

dd32

Message:

Time Shortcode: properly override the $shortcode_tags array when running the time shortcode in comments early.

Calling unset() on the global array wasn't emptying it out, but rather unsetting it in the scope of the function, causing do_shortcode() to run with the original shortcode arrays.

This fixes a case where [code] shortcodes were being run before the plugin responsible was able to hook in (early) to handle the shortcodes.

H/t tobifjellner for noticing the problem.
See ​https://wordpress.slack.com/archives/C02QB8GMM/p1543802741017900

File:

• sites/trunk/wordpress.org/public_html/wp-content/mu-plugins/pub/wporg-time-shortcode.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/mu-plugins/pub/wporg-time-shortcode.php

@@ -162 +162 @@
 
     // Only process the time shortcode.
-    unset( $shortcode_tags );
-    $shortcode_tags['time'] = __NAMESPACE__ . '\time_shortcode';
+    $shortcode_tags = array(
+        'time' =>__NAMESPACE__ . '\time_shortcode'
+    );
 
     // Do the time shortcode on the comment.