Changeset 7972

Timestamp:

12/11/2018 01:04:04 AM (7 years ago)

Author:

dd32

Message:

Gutenberg Theme: Override the CSS 'color' on a:visited for the download button.

This fixes a case where the button ended up as dark text on blue background.

See ​https://github.com/WordPress/gutenberg/issues/12772

Location:

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/gutenberg

Files:

• gutenfront-content.php (modified) (2 diffs)
• js/button-readonly.js (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/gutenberg/gutenfront-content.php

@@ -26 +26 @@
 
 $content .= '<!-- wp:wporg/download-button -->
-<div class="wp-block-wporg-download-button wp-block-button aligncenter"><a class="wp-block-button__link has-background has-strong-blue-background-color" href="' . "https://{$localised_domain}/plugins/gutenberg/" . '" style="background-color:rgb(0,115,170)">' . esc_html__( 'Download Gutenberg Today', 'wporg' ) . '</a></div>
+<div class="wp-block-wporg-download-button wp-block-button aligncenter"><a class="wp-block-button__link has-background has-strong-blue-background-color" href="' . "https://{$localised_domain}/plugins/gutenberg/" . '" style="background-color:rgb(0,115,170);color:#fff">' . esc_html__( 'Download Gutenberg Today', 'wporg' ) . '</a></div>
 <!-- /wp:wporg/download-button -->' . "\n\n";
 
@@ -145 +145 @@
 
 $content .= '<!-- wp:wporg/download-button -->
-<div class="wp-block-wporg-download-button wp-block-button aligncenter"><a class="wp-block-button__link has-background has-strong-blue-background-color" href="' . "https://{$localised_domain}/plugins/gutenberg/" . '" style="background-color:rgb(0,115,170)">' . esc_html__( 'Download Gutenberg Today', 'wporg' ) . '</a></div>
+<div class="wp-block-wporg-download-button wp-block-button aligncenter"><a class="wp-block-button__link has-background has-strong-blue-background-color" href="' . "https://{$localised_domain}/plugins/gutenberg/" . '" style="background-color:rgb(0,115,170);color:#fff">' . esc_html__( 'Download Gutenberg Today', 'wporg' ) . '</a></div>
 <!-- /wp:wporg/download-button -->' . "\n\n";
 

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/gutenberg/js/button-readonly.js

@@ -35 +35 @@
 
         return el(
-            'div', 
+            'div',
             { className: 'wp-block-button align' + props.attributes.align, },
             el(
                 'a',
                 { className: 'wp-block-button__link has-background has-strong-blue-background-color', href: props.attributes.url,
-                    style: { backgroundColor: 'rgb(0,115,170)' },
-                    title: props.attributes.title 
+                    style: { backgroundColor: 'rgb(0,115,170)', color: '#fff' },
+                    title: props.attributes.title
                 },
                 props.attributes.text
-            ) 
+            )
         );
     },
@@ -51 +51 @@
 
         return el(
-            'div', 
+            'div',
             { className: 'wp-block-button align' + props.attributes.align },
             el(
                 'a',
                 { className: 'wp-block-button__link has-background has-strong-blue-background-color', href: props.attributes.url,
-                    style: { backgroundColor: 'rgb(0,115,170)' },
-                    title: props.attributes.title  
+                    style: { backgroundColor: 'rgb(0,115,170)', color: '#fff' },
+                    title: props.attributes.title
                 },
                 props.attributes.text
-            ) 
+            )
         );
     },