Changeset 7976 for sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/javascript/tracker/source/components/filterable-table/row.jsx

Timestamp:

12/17/2018 07:34:12 AM (7 years ago)

Author:

vedjain

Message:

WCPT Application Tracker: Multiple changes in rendering of application status report, see desc.

1. Add customRender option to allow specifying different render logic in application tracker report.
2. Send timestamp for lastUpdated column instead of humanize_time_diff. Move logic for humanize_time_diff to frontend, because its a very simple logic, and would make a easy fix for #2501
3. Use customRender option to display X time ago instead of absolute timestamp.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/javascript/tracker/source/components/filterable-table/row.jsx (modified) (2 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/javascript/tracker/source/components/filterable-table/row.jsx

@@ -3 +3 @@
 export default React.createClass( {
     propTypes : {
-        columns : PropTypes.object,
-        row     : PropTypes.object,
+        columns      : PropTypes.object,
+        row          : PropTypes.object,
+        customRender : PropTypes.object,
     },
 
     getDefaultProps : function() {
         return {
-            columns : {},
-            row     : {},
+            columns      : {},
+            row          : {},
+            customRender : {},
         };
     },
@@ -21 +23 @@
          * shouldn't be displayed, like URLs.
          */
-        for ( let i in this.props.columns ) {
+        for ( let columnName in this.props.columns ) {
             let cellContent = '';
 
-            if ( ! this.props.columns.hasOwnProperty( i ) ) {
+            if ( ! this.props.columns.hasOwnProperty( columnName ) ) {
                 continue;
             }
 
-            if ( this.props.row[ i + 'Url' ] ) {
-                cellContent = <a href={ this.props.row[ i + 'Url' ] }>{ this.props.row[ i ] }</a>;
+            if ( this.props.row[ columnName + 'Url' ] ) {
+                cellContent = <a href={ this.props.row[ columnName + 'Url' ] }>{ this.props.row[ columnName ] }</a>;
+            } else if ( this.props.customRender[ columnName ] ) {
+                cellContent = this.props.customRender[ columnName ]( this.props.row[ columnName ] );
             } else {
-                cellContent = this.props.row[ i ];
+                cellContent = this.props.row[ columnName ];
             }
 
+
             cells.push(
-                <td className={ i } key={ i }>
+                <td className={ columnName } key={ columnName }>
                     { cellContent }
                 </td>