Changeset 7977

Timestamp:

12/17/2018 07:34:19 AM (7 years ago)

Author:

vedjain

Message:

WCPT Application Tracker: Send time from server because client can have clock skew, and therefore cannot be trusted.

Location:

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt

Files:

• javascript/tracker/source/tracker.jsx (modified) (1 diff)
• wcpt-event/tracker.php (modified) (1 diff)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/javascript/tracker/source/tracker.jsx

@@ -13 +13 @@
  * Looks like exact javascript convert of WordPress's human_time_diff, except this always compares from current time, instead of getting two arguments.
  *
- * @param {int} date Unix timestamp date to compare from
+ * @param {int} seconds Seconds ago to convert to human readable time
  *
  * @returns {string} Human readable time ago
  */
-const timeSince = ( date ) => {
-
-    const seconds = Math.floor( (new Date() / 1000 ) - date );
+const timeSince = ( seconds ) => {
 
     let interval = Math.floor(seconds / 31536000);

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-event/tracker.php

@@ -70 +70 @@
             'milestone'  => $milestones[ $post->post_status ],
             'status'     => $statuses[ $post->post_status ],
-            'lastUpdate' => $last_update_timestamp,
+            'lastUpdate' => time() - $last_update_timestamp,
         );
     }