Changeset 7980 for sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/javascript/tracker/source/tracker.jsx

Timestamp:

12/17/2018 07:34:40 AM (7 years ago)

Author:

vedjain

Message:

WCPT Application Tracker: Make sure that time is rendered in biggest possible unit.

Earlier, because of Math.floor, and > comparison, time like 73 seconds would have rendered as 73 seconds ago instead of 1 minute ago, since Math.floor would have rounded seconds/60 to 1. So using >= comparison operator instead of > will fix this behavior.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/javascript/tracker/source/tracker.jsx (modified) (1 diff)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/javascript/tracker/source/tracker.jsx

@@ -21 +21 @@
     let interval = Math.floor(seconds / 31536000);
 
-    if (interval > 1) {
+    if (interval >= 1) {
         return interval + " years";
     }
     interval = Math.floor(seconds / 2592000);
-    if (interval > 1) {
+    if (interval >= 1) {
         return interval + " months";
     }
     interval = Math.floor(seconds / 86400);
-    if (interval > 1) {
+    if (interval >= 1) {
         return interval + " days";
     }
     interval = Math.floor(seconds / 3600);
-    if (interval > 1) {
+    if (interval >= 1) {
         return interval + " hours";
     }
     interval = Math.floor(seconds / 60);
-    if (interval > 1) {
+    if (interval >= 1) {
         return interval + " minutes";
     }