Changeset 8009 for sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-showcase/page-submit.php

Timestamp:

12/21/2018 03:24:08 AM (6 years ago)

Author:

dd32

Message:

Showcase: Add a missing tabindex to the site submit form.
Additionally, this has indexed the fields from 2 onwards as tabindex 1 is used by the assistive techonlogies "Skip to content" link which was causing focus to jump from Name -> Skip to Content -> Email fields.

Props ramizmanked.
Fixes #4021.

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-showcase/page-submit.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-showcase/page-submit.php

@@ -78 +78 @@
 
     <p><label for="submitname"><?php _e( 'Your Name', 'wporg-showcase' ); ?></label><br />
-    <input type="text" name="submitname" id="submitname" class="text" value="<?php echo esc_attr( $submitname ); ?>" size="28" tabindex="1" /></p>
+    <input type="text" name="submitname" id="submitname" class="text" value="<?php echo esc_attr( $submitname ); ?>" size="28" tabindex="2" /></p>
 
     <p><label for="email"><?php _e( 'Your E-mail', 'wporg-showcase'); ?></label><br />
-    <input type="text" name="email" id="email" value="<?php echo esc_attr( $email ); ?>" size="28" tabindex="2" class="text" /></p>
+    <input type="text" name="email" id="email" value="<?php echo esc_attr( $email ); ?>" size="28" tabindex="3" class="text" /></p>
 
     <p><label for="url"><?php _e( 'Site URL', 'wporg-showcase' ); ?></label><br />
-    <input type="text" name="url" id="url" value="<?php echo esc_url( $url ); ?>" size="28" tabindex="3" class="text" /></p>
+    <input type="text" name="url" id="url" value="<?php echo esc_url( $url ); ?>" size="28" tabindex="4" class="text" /></p>
 
     <p><label for="owner"><?php _e( "Do you own this site? (It's okay if you don't - we just want to know for contact purposes.)", 'wporg-showcase' ); ?></label><br />
-    <select name="owner" id="owner">
+    <select name="owner" id="owner" tabindex="5">
         <option value="yes" <?php selected( $owner, 'yes' ); ?> ><?php _e( 'Yes', 'wporg-showcase' ); ?></option>
         <option value="no" <?php selected( $owner, 'no' ); ?> ><?php _e( 'No', 'wporg-showcase' ); ?></option>
@@ -93 +93 @@
 
     <p><label for="description"><?php _e( 'Please describe the site and, if applicable, the person or organization it represents.', 'wporg-showcase' ); ?></label><br />
-    <textarea name="description" id="description" cols="60" rows="4" tabindex="4" class="text"><?php echo esc_textarea( $description ); ?></textarea></p>
+    <textarea name="description" id="description" cols="60" rows="4" tabindex="6" class="text"><?php echo esc_textarea( $description ); ?></textarea></p>
 
     <p><label for="why"><?php _e( 'What justifies this site being added to the WordPress Showcase? What makes it unique or interesting?', 'wporg-showcase' ); ?></label><br />
-    <textarea name="why" id="why" cols="60" rows="4" tabindex="5" class="text"><?php echo esc_textarea( $why ); ?></textarea></p>
+    <textarea name="why" id="why" cols="60" rows="4" tabindex="7" class="text"><?php echo esc_textarea( $why ); ?></textarea></p>
 
     <p class="required"><?php _e( '* All fields are required.', 'wporg-showcase' ); ?></p>
@@ -116 +116 @@
     ?>
 
-    <p><input id="submit" type="submit" tabindex="6" value="<?php esc_attr_e( 'Submit Site', 'wporg-showcase' ); ?>" class="button" /></p>
+    <p><input id="submit" type="submit" tabindex="8" value="<?php esc_attr_e( 'Submit Site', 'wporg-showcase' ); ?>" class="button" /></p>
     <?php do_action( 'comment_form', $post->ID ); ?>
 </form>