Changeset 8066

Timestamp:

01/10/2019 06:05:24 AM (6 years ago)

Author:

dd32

Message:

WordPress.org Main Theme: Use the Serve Happy constants for the PHP requirements to reduce the number of locations it needs updating in.

Props flixos90, dd32.
Fixes #4009.

Location:

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-main

Files:

• page-about-requirements.php (modified) (3 diffs)
• page-download.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-main/page-about-requirements.php

@@ -9 +9 @@
 
 namespace WordPressdotorg\MainTheme;
+use WordPressdotorg\API\Serve_Happy\RECOMMENDED_PHP;
+use WordPressdotorg\API\Serve_Happy\MINIMUM_PHP;
 
 $GLOBALS['menu_items'] = [
@@ -44 +46 @@
                             <?php
                             /* translators: 1: URL to PHP; 2: PHP Version */
-                            printf( wp_kses_post( __( '<a href="%1$s">PHP</a> version %2$s or greater.', 'wporg' ) ), esc_url( 'http://www.php.net/' ), '7.2' );
+                            printf( wp_kses_post( __( '<a href="%1$s">PHP</a> version %2$s or greater.', 'wporg' ) ), esc_url( 'http://www.php.net/' ), RECOMMENDED_PHP );
                             ?>
                         </li>
@@ -73 +75 @@
                             /* translators: 1: PHP Version including; 2: MySQL Version */
                             wp_kses_post( __( 'Note: If you are in a legacy environment where you only have older PHP or MySQL versions, WordPress also works with PHP %1$s+ and MySQL %2$s+, but these versions have reached official End Of Life and as such <strong>may expose your site to security vulnerabilities</strong>.', 'wporg' ) ),
-                            '5.2.4',
+                            MINIMUM_PHP,
                             '5.0'
                         );

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-main/page-download.php

@@ -9 +9 @@
 
 namespace WordPressdotorg\MainTheme;
+use WordPressdotorg\API\Serve_Happy\RECOMMENDED_PHP;
 
 $hosts = [
@@ -147 +148 @@
                             <?php
                             printf(
-                                /* translators: 1: URL to PHP website; 2: URL to MySQL website; 3: URL to MariaDB website */
-                                wp_kses_post( __( 'We recommend servers running version 7.2 or greater of <a href="%1$s">PHP</a> and <a href="%2$s">MySQL</a> version 5.6 <em>OR</em> <a href="%3$s">MariaDB</a> version 10.0 or greater.', 'wporg' ) ),
-                                esc_url( 'http://www.php.net/' ),
+                                /* translators: 1: PHP version; 2: URL to PHP website; 3: URL to MySQL website; 4: MySQL version; 5: URL to MariaDB website; 6: MariaDB version */
+                                wp_kses_post( __( 'We recommend servers running version %1$s or greater of <a href="%2$s">PHP</a> and <a href="%3$s">MySQL</a> version %4$s <em>OR</em> <a href="%5$s">MariaDB</a> version %6$s or greater.', 'wporg' ) ),
+                                RECOMMENDED_PHP,
+                                esc_url( 'https://www.php.net/' ),
                                 esc_url( 'https://www.mysql.com/' ),
-                                esc_url( 'https://mariadb.org/' )
+                                '5.6',
+                                esc_url( 'https://mariadb.org/' ),
+                                '10.0'
                             );
                             ?>