Changeset 8084

Timestamp:

01/15/2019 11:02:54 AM (8 years ago)

Author:

vedjain

Message:

WCPT: Do not send notifications when Old and New status are same

We would have already notified when Meetup or WordCamp application would have been accepted for first time. So no need to do it again.

Location:

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt

Files:

• wcpt-event/notification.php (modified) (1 diff)
• wcpt-meetup/class-meetup-admin.php (modified) (1 diff)
• wcpt-wordcamp/wordcamp-admin.php (modified) (1 diff)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-event/notification.php

@@ -110 +110 @@
  */
 function get_user_nicenames_from_ids( $user_ids ) {
+        if ( empty( $user_ids ) ) {
+                return array();
+        }
+
         $user_query = new WP_User_Query( array( 'include' => $user_ids, 'fields'  => array( 'user_nicename' ), ) );
 

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-meetup/class-meetup-admin.php

@@ -498 +498 @@
                         }
 
-                        if ( 'wcpt-mtp-active' === $new_status ) {
+                        if ( 'wcpt-mtp-active' === $new_status && 'wcpt-mtp-active' !== $old_status ) {
                                 return $this->notify_new_meetup_group_in_slack( $meetup );
-                        } elseif ( 'wcpt-mtp-rejected' === $new_status ) {
+                        } elseif ( 'wcpt-mtp-rejected' === $new_status && 'wcpt-mtp-rejected' !== $old_status ) {
                                 $location = get_post_meta( $meetup->ID, 'Meetup Location', true );
                                 return $this->schedule_decline_notification( $meetup, $this->get_event_label(), $location );

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-wordcamp/wordcamp-admin.php

@@ -725 +725 @@
                         }
 
-                        if ( 'wcpt-scheduled' === $new_status ) {
+                        if ( 'wcpt-scheduled' === $new_status && 'wcpt-scheduled' !== $old_status ) {
                                 return $this->notify_new_wordcamp_in_slack( $wordcamp );
-                        } elseif ( 'wcpt-rejected' === $new_status ) {
+                        } elseif ( 'wcpt-rejected' === $new_status && 'wcpt-rejected' !== $old_status ) {
                                 $location = get_post_meta( $wordcamp->ID, 'Location', true );
                                 return $this->schedule_decline_notification( $wordcamp, 'WordCamp', $location );