Changeset 8089

Timestamp:

01/17/2019 02:46:31 AM (6 years ago)

Author:

dd32

Message:

Trac: When performing @mentions, use the users nicename when the username contains a space.

This keeps the current ProperCase usernames and only suggests nicenames when required.

Fixes #2539.

File:

• sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js

@@ -808 +808 @@
                     $( $( '.change .username' ).get().reverse() ).each( function() {
                         var username = $(this).data( 'username' );
+
+                        // Override the username with the nicename if it differs by more than just case (ie. spaces, etc)
+                        if (
+                            $(this).data( 'nicename' ) &&
+                            username.toLowerCase() != $(this).data( 'nicename' ).toLowerCase() &&
+                            wpTrac.currentUser !== username
+                        ) {
+                            username = $(this).data( 'nicename' );
+                        }
+
                         if (
                             typeof username !== 'undefined' &&
@@ -813 +823 @@
                             -1 === $.inArray( username, exclude )
                         ) {
-                            users.push( $(this).data( 'username' ) );
+                            users.push( username );
                         }
                     });
@@ -819 +829 @@
                     // Add ticket reporter.
                     var ticketReporter = $.trim( $( '#ticket td[headers="h_reporter"]' ).text() );
+                    var ticketReporterNicename = $( '#ticket td[headers="h_reporter"] a' ).data( 'nicename' );
+                    // Override the username with the nicename if it differs by more than just case (ie. spaces, etc)
+                    if (
+                        ticketReporter &&
+                        ticketReporterNicename &&
+                        ticketReporter !== wpTrac.currentUser &&
+                        ticketReporter.toLowerCase() !== ticketReporterNicename.toLowerCase()
+                    ) {
+                        ticketReporter = ticketReporterNicename;
+                    }
+
                     if ( ticketReporter && -1 === $.inArray( ticketReporter, users ) ) {
                         users.push( ticketReporter );