Changeset 8093 for sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/wcorg-misc.php

Timestamp:

01/18/2019 01:01:30 AM (6 years ago)

Author:

coreymckrill

Message:

WordCamp: Add ignore list for error slack notifications

Some errors are triggered by 3rd party plugins or Core itself, and these mostly
don't need to get piped into Slack. This gives us a mechanism for muting
noisy error notifications that we don't plan to fix anytime soon.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/wcorg-misc.php (modified) (3 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/wcorg-misc.php

@@ -467 +467 @@
     }
 
-    $error_whitelist = array(
+    $error_safelist = [
         E_ERROR,
         E_USER_ERROR,
@@ -476 +476 @@
         E_DEPRECATED,
         E_WARNING,
-    );
-
-    if ( ! in_array( $err_no, $error_whitelist ) ) {
+    ];
+
+    if ( ! in_array( $err_no, $error_safelist ) ) {
+        return false;
+    }
+
+    // Always use the ABSPATH constant in the keys here to avoid path disclosure.
+    $error_ignorelist = [
+        // See https://core.trac.wordpress.org/ticket/29204
+        ABSPATH . 'wp-includes/SimplePie/Registry.php:215' => 'Non-static method WP_Feed_Cache::create() should not be called statically',
+    ];
+
+    if ( isset( $error_ignorelist[ "$file:$line" ] ) && false !== strpos( $err_msg, $error_ignorelist[ "$file:$line" ] ) ) {
         return false;
     }
@@ -516 +526 @@
     $domain    = get_site_url();
     $page_slug = esc_html( trim( $_SERVER['REQUEST_URI'], '/' ) );
-    $text      = $text . "Message : \"$err_msg\" occured on \"$file:$line\" \n Domain: $domain \n Page: $page_slug \n Error type: $err_no";
+    $text      = $text . "Message : \"$err_msg\" occurred on \"$file:$line\" \n Domain: $domain \n Page: $page_slug \n Error type: $err_no";
 
     $message = array(