Changeset 8103

Timestamp:

01/18/2019 07:15:25 PM (6 years ago)

Author:

coreymckrill

Message:

WordCamp Post Types: Fix widgets without titles showing boolean value

A regression was introduced in r8094 that caused widgets without titles
to show 1 instead of having an empty string.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wc-post-types/inc/widgets.php (modified) (4 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wc-post-types/inc/widgets.php

@@ -23 +23 @@
 
         extract( $args );
-        $title = ( isset( $instance['title'] ) ) ?: '';
+        $title = ( isset( $instance['title'] ) ) ? $instance['title'] : '';
         $title = apply_filters( 'widget_title', $title, $instance, $this->id_base );
 
@@ -130 +130 @@
 
         $transient_key     = 'wcpt-' . md5( $args['widget_id'] );
-        $instance['title'] = ( isset( $instance['title'] ) ) ?: '';
+        $instance['title'] = ( isset( $instance['title'] ) ) ? $instance['title'] : '';
         $instance['title'] = apply_filters( 'widget_title', $instance['title'], $instance, $this->id_base );
 
@@ -245 +245 @@
 
         $transient_key     = 'wcpt-' . md5( $args['widget_id'] );
-        $instance['title'] = ( isset( $instance['title'] ) ) ?: '';
+        $instance['title'] = ( isset( $instance['title'] ) ) ? $instance['title'] : '';
         $instance['title'] = apply_filters( 'widget_title', $instance['title'], $instance, $this->id_base );
 
@@ -364 +364 @@
 
         $transient_key     = 'wcpt-' . md5( $args['widget_id'] );
-        $instance['title'] = ( isset( $instance['title'] ) ) ?: '';
+        $instance['title'] = ( isset( $instance['title'] ) ) ? $instance['title'] : '';
         $instance['title'] = apply_filters( 'widget_title', $instance['title'], $instance, $this->id_base );