Changeset 8133

Timestamp:

01/24/2019 08:32:29 AM (6 years ago)

Author:

vedjain

Message:

WCPT: Move post type check to before nonce check.

This was giving an error sometimes while submitting a post, looks like because metabox_save is getting enqueued some other place as well.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-event/class-event-admin.php (modified) (2 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-event/class-event-admin.php

@@ -413 +413 @@
         }
 
-        // Make sure the requset came from the edit post screen.
+        if ( $this->get_event_type() !== $post->post_status ) {
+            return;
+        }
+
+        // Make sure the request came from the edit post screen.
         if ( empty( $_POST['_wpnonce'] ) || ! wp_verify_nonce( $_POST['_wpnonce'], 'update-post_' . $post_id ) ) {
             die( 'Unable to verify nonce' );
@@ -420 +424 @@
         // Don't add/remove meta on trash, untrash, restore, etc.
         if ( empty( $_POST['action'] ) || 'editpost' !== $_POST['action'] ) {
-            return;
-        }
-
-        if ( $this->get_event_type() !== get_post_type() ) {
             return;
         }