Changeset 8136 for sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/reimbursement-request.php

Timestamp:

01/24/2019 02:31:10 PM (6 years ago)

Author:

coreymckrill

Message:

WordCamp Payments: Prevent submission of requests that have no documentation

For both Payment Requests and Reimbursement Requests:

• Add a method to check and see if the request post can be submitted. Currently this just checks to see if the post has one or more files attached to it.
• When the post fails the check, show a note in the Status metabox that documentation must be attached first, and don't render the Submit for Review button.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/reimbursement-request.php (modified) (13 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/reimbursement-request.php

@@ -6 +6 @@
 
 namespace WordCamp\Budgets\Reimbursement_Requests;
+defined( 'WPINC' ) or die();
+
+use WP_Post;
 use WCP_Encryption;
 use WordCamp\Utilities;
-
-defined( 'WPINC' ) or die();
+use WordCamp_Budgets;
 
 const POST_TYPE = 'wcb_reimbursement';
@@ -251 +253 @@
  * submitted yet, or if we've asked for more information.
  *
- * @param \WP_Post $post
+ * @param WP_Post $post
  *
  * @return bool
@@ -263 +265 @@
  * Render the Status metabox
  *
- * @param \WP_Post $post
+ * @param WP_Post $post
  */
 function render_status_metabox( $post ) {
@@ -286 +288 @@
     $submit_text = esc_html_x( 'Update', 'payment request', 'wordcamporg' );
     $submit_note = '';
+    $submit_note_class = 'warning';
 
     if ( current_user_can( 'manage_network' ) ) {
         $current_user_can_edit_request = true;
     } elseif ( in_array( $post->post_status, $editable_statuses ) ) {
-        $submit_text = esc_html__( 'Submit for Review', 'wordcamporg' );
-        $submit_note = esc_html__( 'Once submitted for review, this request can not be edited.', 'wordcamporg' );
+        if ( WordCamp_Budgets::can_submit_request( $post ) ) {
+            $submit_text = __( 'Submit for Review', 'wordcamporg' );
+            $submit_note = __( 'Once submitted for review, this request cannot be edited.', 'wordcamporg' );
+        } else {
+            $submit_note = __( 'Please add an invoice or other supporting documentation in the Files section and save the draft.', 'wordcamporg' );
+            $submit_note_class = 'error';
+        }
+
         $current_user_can_edit_request = true;
     }
@@ -300 +309 @@
     $request_id         = get_current_blog_id() . '-' . $post->ID;
     $requested_by       = \WordCamp_Budgets::get_requester_name( $post->post_author );
-    $update_text        = current_user_can( 'manage_network' ) ? esc_html__( 'Update Request', 'wordcamporg' ) : esc_html__( 'Send Request', 'wordcamporg' );
 
     require_once( dirname( __DIR__ ) . '/views/reimbursement-request/metabox-status.php' );
@@ -308 +316 @@
  * Render the Notes metabox
  *
- * @param \WP_Post $post
+ * @param WP_Post $post
  */
 function render_notes_metabox( $post ) {
@@ -321 +329 @@
  * Render General Information Metabox
  *
- * @param \WP_Post $post
+ * @param WP_Post $post
  *
  */
@@ -365 +373 @@
  * Render Expenses Metabox
  *
- * @param \WP_Post $post
+ * @param WP_Post $post
  *
  */
@@ -440 +448 @@
  *
  * @param int      $post_id
- * @param \WP_Post $post
+ * @param WP_Post $post
  */
 function save_request( $post_id, $post ) {
@@ -465 +473 @@
      * user_can_edit_request() instead.
      */
-    $original_post = new \WP_Post( (object) array( 'post_status' => $_POST['original_post_status'] ) );
+    $original_post = new WP_Post( (object) array( 'post_status' => $_POST['original_post_status'] ) );
 
     if ( user_can_edit_request( $original_post ) ) {
@@ -671 +679 @@
  * Validate and save expense data
  *
- * @param \WP_Post $post
+ * @param WP_Post $post
  * @param array    $expenses
  */
@@ -716 +724 @@
  * Notify WordCamp Central or the request author when new notes are added
  *
- * @param \WP_Post $request
+ * @param WP_Post $request
  * @param array    $note
  */
@@ -762 +770 @@
  * @param string   $new_status
  * @param string   $old_status
- * @param \WP_Post $request
+ * @param WP_Post $request
  */
 function notify_organizer_request_updated( $new_status, $old_status, $request ) {