Changeset 8176

Timestamp:

02/02/2019 09:51:16 AM (6 years ago)

Author:

ocean90

Message:

Slack: Don't include links in pretext fields, use title and title_link instead.

Makes the link clickable in mobile apps and also follows Slack's guidelines for building messages.

Location:

sites/trunk/common/includes/slack/trac

Files:

• new-ticket.php (modified) (2 diffs)
• ticket.php (modified) (1 diff)

sites/trunk/common/includes/slack/trac/new-ticket.php

@@ -23 +23 @@
         }
 
-        $attachment['pretext'] = preg_replace( '/: /', ": \n", $attachment['text'], 1 );
-        $attachment['mrkdwn_in'][] = 'pretext';
-        $attachment['text'] = Trac::format_for_slack( $this->description );
+        $attachment['pretext'] = sprintf( 'New %s opened by %s', self::get_type( $this->type ), $this->reporter );
+
+        $attachment['text']  = Trac::format_for_slack( $this->description );
         $attachment['color'] = $this->trac->get_color();
+
         return $attachment;
     }
@@ -56 +57 @@
 
         return $attachments;
-    }   
+    }
 }

sites/trunk/common/includes/slack/trac/ticket.php

@@ -38 +38 @@
             return false;
         }
+
+        unset( $attachment['text'] ); // Moved to title and title_link.
+
+        $attachment['title']      = sprintf( '#%s: %s', $this->id, htmlspecialchars( $this->summary, ENT_NOQUOTES ) );
+        $attachment['title_link'] = $this->get_url();
 
         $attachment['fields'] = self::get_ticket_fields( $this->data );